From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcBb3-00044I-Bi for qemu-devel@nongnu.org; Tue, 23 Aug 2016 09:18:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcBb0-0003id-Rj for qemu-devel@nongnu.org; Tue, 23 Aug 2016 09:18:28 -0400 Date: Tue, 23 Aug 2016 08:19:43 -0400 From: David Gibson Message-ID: <20160823121943.GC20266@littlecatz> References: <1471487270-1490-1-git-send-email-programmingkidx@gmail.com> <20160818023709.482797.68673@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WfZ7S8PLGjBY9Voh" Content-Disposition: inline In-Reply-To: <20160818023709.482797.68673@ex-std-node742.prod.rhcloud.com> Subject: Re: [Qemu-devel] [PATCH v5 0/4] ADB improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: programmingkidx@gmail.com, famz@redhat.com, qemu-ppc@nongnu.org --WfZ7S8PLGjBY9Voh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2016 at 07:37:16PM -0700, no-reply@patchew.org wrote: > Hi, >=20 > Your series seems to have some coding style problems. See output below for > more information: >=20 > Message-id: 1471487270-1490-1-git-send-email-programmingkidx@gmail.com > Subject: [Qemu-devel] [PATCH v5 0/4] ADB improvements > Type: series >=20 > =3D=3D=3D TEST SCRIPT BEGIN =3D=3D=3D > #!/bin/bash >=20 > BASE=3Dbase > n=3D1 > total=3D$(git log --oneline $BASE.. | wc -l) > failed=3D0 >=20 > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True >=20 > commits=3D"$(git log --format=3D%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=3D%s $= c)..." > if ! git show $c --format=3Demail | ./scripts/checkpatch.pl --mailbac= k -; then > failed=3D1 > echo > fi > n=3D$((n+1)) > done >=20 > exit $failed > =3D=3D=3D TEST SCRIPT END =3D=3D=3D >=20 > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/1471487270-1490-1-git-send-email-programming= kidx@gmail.com -> patchew/1471487270-1490-1-git-send-email-programmingkidx@= gmail.com > Switched to a new branch 'test' > 8e862cb adb.c: prevent NO_KEY value from going to guest > 649cccc adb.c: correct several key assignments > f4950b2 adb.c: add support for QKeyCode > db1d3d7 adb-keys.h: initial commit >=20 > =3D=3D=3D OUTPUT BEGIN =3D=3D=3D > Checking PATCH 1/4: adb-keys.h: initial commit... > ERROR: line over 90 characters > #30: FILE: include/hw/input/adb-keys.h:14: > + * Additional information: http://www.archive.org/stream/apple-guide-ma= cintosh-family-hardware/Apple_Guide_to_the_Macintosh_Family_Hardware_2e#pag= e/n345/mode/2up This error can be ignored - the line is only long because of the stupidly long URL, which should not be broken. > total: 1 errors, 0 warnings, 141 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. >=20 > Checking PATCH 2/4: adb.c: add support for QKeyCode... > Checking PATCH 3/4: adb.c: correct several key assignments... > Checking PATCH 4/4: adb.c: prevent NO_KEY value from going to guest... > =3D=3D=3D OUTPUT END =3D=3D=3D >=20 > Test command exited with code: 1 >=20 >=20 > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --WfZ7S8PLGjBY9Voh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXvD9fAAoJEGw4ysog2bOSRbcP+gIlEKaPF2jcZZrU7LOmRhoI 5zskGjjDnBwT+qsphH+NRk5Z0qnfk0DiD5a6GEQoIaseWucxSdfDjH9TdU0z/2p0 XmzuRpRH7o+vdQ4YK6mIb+uTRs6gOlNzSWNIQRTSgkxp/gZx2KNbSTMhD14tL99A Onq2uBb7FgXSPoHjbyoNNstdQeji3V7qhOtIPzRcKNGrHdw1gBhXQX5URnp3Jm4F zqKaGbaRfIKHkhnEKNCx3thRPN+siVzcMAEV/kNjn4q0BZCXDVuZ3dhND2sO6m3T JSSO1sL+hwuxeb/a7OBhH06US7b6dOtzKC6yYri1pOZjZIQThwUScvQpVueBlbNB gEbS/r/qnG+jcyRRRzs4Zhw5P+J1MiPCRDhWMPwMB4X4PviO4z2FarsqhHMj+YEy tF8zLl+6FArsYdBukPZC36s4guS5Qo7NW/6J7p0apHxSI2ArSysMW1q9eJ0/dQzi lc141LjlZ5L+BPjzv0MDWzq8fxO59TG4TbAVXZDPBJinz27qD0bdOTuXtufdSBvG OVYGZTWSnZF4wcD1Ii73cPjCQMXULmYotHa8fwALq2aOY0azpJyHimL0o6/5MQzf 9yJbrOX6hgCRbyPmA92v+RDjWo2QUMBijVM2BWYfmF+XIDaGaivbbnIkLeQRMFNQ X25Mb7ocRQWdQxkPLFBY =Rvha -----END PGP SIGNATURE----- --WfZ7S8PLGjBY9Voh--