From: "Daniel P. Berrange" <berrange@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, jasowang@redhat.com, crobinso@redhat.com,
ashijeetacharya@gmail.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again
Date: Tue, 23 Aug 2016 09:13:38 -0400 [thread overview]
Message-ID: <20160823131338.GA32515@redhat.com> (raw)
In-Reply-To: <57BC28EA.8070700@cn.fujitsu.com>
On Tue, Aug 23, 2016 at 06:43:54PM +0800, Cao jin wrote:
> Hi,
> I just noticed you still using the old-style non-blocking connect(which will
> still block when query DNS), which will be removed (suggested by Daniel),
> but the patch is still on the way. So I guess maybe you should switch to
> QIOChannel way.
>
> FYI:
> http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg06386.html
> http://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg00046.html
Yes, switching to QIOChannel would be good, but that is certainly not
something that's acceptable for 2.7.0. We need Marc-André's fix in the
short term for this release. If someone wants to do a QIOChannel
conversion for 2.8.0/2.9.0/etc that's an option...
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-08-23 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:45 [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions Marc-André Lureau
2016-08-23 9:45 ` [Qemu-devel] [PATCH for-2.7 1/2] net: fix socket connect Marc-André Lureau
2016-08-23 9:45 ` [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again Marc-André Lureau
2016-08-23 10:43 ` Cao jin
2016-08-23 13:13 ` Daniel P. Berrange [this message]
2016-08-23 13:33 ` Marc-André Lureau
2016-08-30 12:07 ` [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823131338.GA32515@redhat.com \
--to=berrange@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=crobinso@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).