From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcBWX-0002EV-CX for qemu-devel@nongnu.org; Tue, 23 Aug 2016 09:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcBWS-0002Zf-N6 for qemu-devel@nongnu.org; Tue, 23 Aug 2016 09:13:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcBWS-0002ZM-HN for qemu-devel@nongnu.org; Tue, 23 Aug 2016 09:13:44 -0400 Date: Tue, 23 Aug 2016 09:13:38 -0400 From: "Daniel P. Berrange" Message-ID: <20160823131338.GA32515@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160823094537.8782-1-marcandre.lureau@redhat.com> <20160823094537.8782-3-marcandre.lureau@redhat.com> <57BC28EA.8070700@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <57BC28EA.8070700@cn.fujitsu.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org, jasowang@redhat.com, crobinso@redhat.com, ashijeetacharya@gmail.com, pbonzini@redhat.com On Tue, Aug 23, 2016 at 06:43:54PM +0800, Cao jin wrote: > Hi, > I just noticed you still using the old-style non-blocking connect(which= will > still block when query DNS), which will be removed (suggested by Daniel= ), > but the patch is still on the way. So I guess maybe you should switch t= o > QIOChannel way. >=20 > FYI: > http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg06386.html > http://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg00046.html Yes, switching to QIOChannel would be good, but that is certainly not something that's acceptable for 2.7.0. We need Marc-Andr=C3=A9's fix in t= he short term for this release. If someone wants to do a QIOChannel conversion for 2.8.0/2.9.0/etc that's an option... Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|