From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com,
David Hildenbrand <dahi@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PATCH for-2.8 30/38] s390x/kvm: disable host model for problematic compat machines
Date: Mon, 29 Aug 2016 13:45:22 +0200 [thread overview]
Message-ID: <20160829114530.10842-31-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160829114530.10842-1-cornelia.huck@de.ibm.com>
From: David Hildenbrand <dahi@linux.vnet.ibm.com>
Compatibility machines that touch runtime-instrumentation should not
be used with the CPU model. Otherwise the host model will look different,
depending on the QEMU machine QEMU has been started with.
So let's simply disable the host model for existing compatibility machines
that all disable ri. This, in return, disables the CPU model for these
compat machines completely.
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Message-Id: <1472062266-53206-23-git-send-email-dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
target-s390x/kvm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index bbf8b2a..d40ef09 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -2481,6 +2481,10 @@ static int configure_cpu_feat(const S390FeatBitmap features)
bool kvm_s390_cpu_models_supported(void)
{
+ if (!ri_allowed()) {
+ /* compatibility machines interfere with the cpu model */
+ return false;
+ }
return kvm_vm_check_attr(kvm_state, KVM_S390_VM_CPU_MODEL,
KVM_S390_VM_CPU_MACHINE) &&
kvm_vm_check_attr(kvm_state, KVM_S390_VM_CPU_MODEL,
--
2.9.3
next prev parent reply other threads:[~2016-08-29 11:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 11:44 [Qemu-devel] [PATCH for-2.8 00/38] s390x patches for 2.8 Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 01/38] s390x: add compat machine " Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 02/38] s390x/pci: return directly if create zpci failed Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 03/38] s390x/pci: assert zpci always existing Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 04/38] s390/sclp: cache the sclp device Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 05/38] s390x: wrap flic savevm calls into vmstate Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 06/38] s390x/ioinst: advertise fcs facility Cornelia Huck
2016-08-29 11:44 ` [Qemu-devel] [PATCH for-2.8 07/38] s390x/css: handle cssid 255 correctly Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 08/38] linux-headers: update Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 09/38] s390x/kvm: 2 byte software breakpoint support Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 10/38] qmp: details about CPU definitions in query-cpu-definitions Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 11/38] s390x/cpumodel: "host" and "qemu" as CPU subclasses Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 12/38] s390x/cpumodel: expose CPU class properties Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 13/38] s390x/cpumodel: introduce CPU features Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 14/38] s390x/cpumodel: generate CPU feature lists for CPU models Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 15/38] s390x/cpumodel: generate CPU feature group lists Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 16/38] s390x/cpumodel: introduce CPU feature group definitions Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 17/38] s390x/cpumodel: register defined CPU models as subclasses Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 18/38] s390x/cpumodel: store the CPU model in the CPU instance Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 19/38] s390x/cpumodel: expose features and feature groups as properties Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 20/38] s390x/cpumodel: let the CPU model handle feature checks Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 21/38] s390x/cpumodel: check and apply the CPU model Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 22/38] s390x/sclp: factor out preparation of cpu entries Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 23/38] s390x/sclp: introduce sclp feature blocks Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 24/38] s390x/sclp: indicate sclp features Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 25/38] s390x/sclp: propagate the ibc val (lowest and unblocked ibc) Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 26/38] s390x/sclp: propagate the mha via sclp Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 27/38] s390x/sclp: propagate hmfai Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 28/38] s390x/kvm: allow runtime-instrumentation for "none" machine Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 29/38] s390x/kvm: implement CPU model support Cornelia Huck
2016-08-29 11:45 ` Cornelia Huck [this message]
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 31/38] s390x/kvm: let the CPU model control CMM(A) Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 32/38] s390x/kvm: don't enable key wrapping if msa3 is disabled Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 33/38] qmp: add QMP interface "query-cpu-model-expansion" Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 34/38] qmp: add QMP interface "query-cpu-model-comparison" Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 35/38] qmp: add QMP interface "query-cpu-model-baseline" Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 36/38] s390x/cpumodel: implement QMP interface "query-cpu-model-expansion" Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 37/38] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison" Cornelia Huck
2016-08-29 11:45 ` [Qemu-devel] [PATCH for-2.8 38/38] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline" Cornelia Huck
2016-08-29 15:39 ` [Qemu-devel] [PATCH for-2.8 00/38] s390x patches for 2.8 no-reply
2016-09-05 7:28 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829114530.10842-31-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).