Re: [Qemu-devel] [PATCH for 2.8 00/11] virtio/vhost DMAR support

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH for 2.8 00/11] virtio/vhost DMAR support
Type: series
Message-id: 1472526419-5900-1-git-send-email-jasowang@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1472526419-5900-1-git-send-email-jasowang@redhat.com -> patchew/1472526419-5900-1-git-send-email-jasowang@redhat.com
Switched to a new branch 'test'
321c6b2 vhost_net: device IOTLB support
7a3b4b7 Revert "intel_iommu: Throw hw_error on notify_started"
9b0d39c memory: handle alias for iommu notifier
05d5b5f acpi: add ATSR for q35
42f3929 virtio-pci: address space translation service (ATS) support
8668581 intel_iommu: support device iotlb descriptor
5cc4f42 exec: introduce address_space_get_iotlb_entry()
136e6e9 intel_iommu: allocate new key when creating new address space
25a674b intel_iommu: name vtd address space with devfn
f5d36b8 virtio: convert to use DMA api
045aae2 linux-headers: update to 4.8-rc4

=== OUTPUT BEGIN ===
Checking PATCH 1/11: linux-headers: update to 4.8-rc4...
Checking PATCH 2/11: virtio: convert to use DMA api...
WARNING: line over 80 characters
#163: FILE: hw/virtio/virtio.c:256:
+        dma_memory_unmap(dma_as, elem->in_sg[i].iov_base, elem->in_sg[i].iov_len,

WARNING: line over 80 characters
#186: FILE: hw/virtio/virtio.c:458:
+                               unsigned int *p_num_sg, hwaddr *addr, struct iovec *iov,

ERROR: spaces required around that ':' (ctx:VxE)
#197: FILE: hw/virtio/virtio.c:480:
+                                              DMA_DIRECTION_FROM_DEVICE:
                                                                        ^

ERROR: braces {} are necessary for all arms of this statement
#287: FILE: hw/virtio/virtio.c:749:
+    if (virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM) &&
[...]

total: 2 errors, 2 warnings, 346 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/11: intel_iommu: name vtd address space with devfn...
Checking PATCH 4/11: intel_iommu: allocate new key when creating new address space...
Checking PATCH 5/11: exec: introduce address_space_get_iotlb_entry()...
Checking PATCH 6/11: intel_iommu: support device iotlb descriptor...
ERROR: use ctz64() instead of ffsll()
#93: FILE: hw/i386/intel_iommu.c:1485:
+        sz = 1 << ffsll(~(addr | (VTD_PAGE_MASK_4K - 1)));

total: 1 errors, 0 warnings, 177 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/11: virtio-pci: address space translation service (ATS) support...
Checking PATCH 8/11: acpi: add ATSR for q35...
Checking PATCH 9/11: memory: handle alias for iommu notifier...
Checking PATCH 10/11: Revert "intel_iommu: Throw hw_error on notify_started"...
Checking PATCH 11/11: vhost_net: device IOTLB support...
ERROR: space required before the open parenthesis '('
#40: FILE: hw/virtio/vhost-backend.c:181:
+    while((len = read((uintptr_t)dev->opaque, &msg, sizeof msg)) > 0) {

ERROR: spaces required around that '+' (ctx:WxV)
#354: FILE: hw/virtio/vhost.c:1101:
+                                                       iotlb->addr_mask +1)) {
                                                                         ^

ERROR: if this code is redundant consider removing it
#411: FILE: hw/virtio/vhost.c:1426:
+#if 0

ERROR: braces {} are necessary for all arms of this statement
#550: FILE: include/hw/virtio/virtio-access.h:211:
+    if (mr->iommu_ops)
[...]
+    else
[...]

ERROR: suspect code indent for conditional statements (4, 6)
#561: FILE: include/hw/virtio/virtio-access.h:222:
+    if (!mr_has_iommu_ops(dma_as->root)) {
+      return dma_memory_map(dma_as, addr, plen, is_write ?

ERROR: suspect code indent for conditional statements (4, 6)
#577: FILE: include/hw/virtio/virtio-access.h:238:
+    if (!mr_has_iommu_ops(dma_as->root)) {
+      dma_memory_unmap(dma_as, buffer, len, is_write ?

total: 6 errors, 0 warnings, 519 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org