From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bea3h-000159-Dx for qemu-devel@nongnu.org; Mon, 29 Aug 2016 23:49:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bea3d-0004XG-7o for qemu-devel@nongnu.org; Mon, 29 Aug 2016 23:49:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bea3d-0004XC-2X for qemu-devel@nongnu.org; Mon, 29 Aug 2016 23:49:53 -0400 Date: Tue, 30 Aug 2016 06:49:51 +0300 From: "Michael S. Tsirkin" Message-ID: <20160830064857-mutt-send-email-mst@kernel.org> References: <1472523968-9540-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Alex Williamson , Cornelia Huck On Tue, Aug 30, 2016 at 11:16:25AM +0800, Jason Wang wrote: >=20 >=20 > On 2016=E5=B9=B408=E6=9C=8830=E6=97=A5 10:27, Michael S. Tsirkin wrote: > > Legacy virtio devices always bypassed an IOMMU, so using them with vf= io was > > never safe. >=20 > And it actually won't work since GPA is assumed in the device. So I'm n= ot > sure this is must since we should get a IOMMU fault in this case. We won't get an IOMMU fault for legacy systems since they bypass the IOMMU. Instead guest userspace will get full access to all of guest memory through the device. > > This adds a quirk detecting these and disabling VFIO unless the > > noiommu mode is used. At the moment, this only applies to virtio-pci= devices. > >=20 > > The patch might make sense on stable as well. > >=20 > > Michael S. Tsirkin (2): > > vfio: report group noiommu status > > vfio: add virtio pci quirk > >=20 > > drivers/vfio/pci/vfio_pci_private.h | 1 + > > include/linux/vfio.h | 2 + > > drivers/vfio/pci/vfio_pci.c | 14 ++++ > > drivers/vfio/pci/vfio_pci_virtio.c | 140 +++++++++++++++++++++++++= +++++++++++ > > drivers/vfio/vfio.c | 12 ++++ > > drivers/vfio/pci/Makefile | 1 + > > 6 files changed, 170 insertions(+) > > create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c > >=20