From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfvdA-0004sv-QU for qemu-devel@nongnu.org; Fri, 02 Sep 2016 17:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfvd4-0007xI-R8 for qemu-devel@nongnu.org; Fri, 02 Sep 2016 17:04:07 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:33826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfvd4-0007xD-My for qemu-devel@nongnu.org; Fri, 02 Sep 2016 17:04:02 -0400 Received: by mail-qk0-x242.google.com with SMTP id r128so8583982qkc.1 for ; Fri, 02 Sep 2016 14:04:02 -0700 (PDT) Date: Fri, 2 Sep 2016 17:03:58 -0400 From: Stefan Hajnoczi Message-ID: <20160902210358.GF21771@stefanha-x1.localdomain> References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <1470756748-18933-10-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TU+u6i6jrDPzmlWF" Content-Disposition: inline In-Reply-To: <1470756748-18933-10-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 09/60] trace: remove use of TRACE_VCPU_EVENT_COUNT in cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi --TU+u6i6jrDPzmlWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 09, 2016 at 04:31:37PM +0100, Daniel P. Berrange wrote: > +/* Keep this a multiple of 8, or better yet a multiple > + * of the platform word size, since the struct > + * will be padded out to that regardless. > + */ > +#define TRACE_MAX_VCPU_EVENT 32 Hard-coding this is awkward. Can it be generated by tracetool at build time so the bitmap is always large enough without manually bumping this definition? Stefan --TU+u6i6jrDPzmlWF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJXyek+AAoJEJykq7OBq3PI404H+wdiYf2iFHc317RCt+pYFCyB JVVrklL/8GlBnKDyVGf2392xMGndtyc9xmRQAIZ5jdci3kBBnf1pgxTsBJWp3hVq +RSvXrJj0MFlfKELW9nv9sCwLObgrCinAWo62EJvB9M84SDLFVm1or8uSbL9u/dg mxNv9kvpIGqmjl9aAjztP+a9yegfAQR95Xr5ZR/bhsgStXkX0cGLidD3IrgSlBTA 5N6uWYMCosco0531ViLMRDVWQ8W1c/sLX5hn4cXsAOwiXcAqO6BUYAU2OlSXtuyX Q5m9uluPArPJFHTJLM+2gyYNIRyZflSgWMl4UB4Uz5kBnJIvJ3egoraR6qDD154= =ZUwM -----END PGP SIGNATURE----- --TU+u6i6jrDPzmlWF--