From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trace: Allow events without arguments
Date: Mon, 5 Sep 2016 13:49:43 -0400 [thread overview]
Message-ID: <20160905174943.GE24387@stefanha-x1.localdomain> (raw)
In-Reply-To: <147220276782.31645.5491006457066656304.stgit@fimbulvetr.bsc.es>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Fri, Aug 26, 2016 at 11:12:47AM +0200, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> scripts/tracetool/__init__.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index be24039..96657e6 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -72,6 +72,11 @@ class Arguments:
> arg_str : str
> String describing the event arguments.
> """
> + # check for empty argument list
> + arg_str = arg_str.strip()
> + if arg_str == "":
> + return Arguments([])
> +
Why is this necessary? C syntax uses f(void) and not f().
We already have trace events with no argument. They use the correct C
syntax.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-09-05 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 9:12 [Qemu-devel] [PATCH] trace: Allow events without arguments Lluís Vilanova
2016-09-05 17:49 ` Stefan Hajnoczi [this message]
2016-09-06 8:47 ` Lluís Vilanova
2016-09-13 15:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905174943.GE24387@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).