From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, afaerber@suse.de,
armbru@redhat.com, arei.gonglei@huawei.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] qom-get [for 2.8]
Date: Tue, 6 Sep 2016 11:10:53 +0100 [thread overview]
Message-ID: <20160906101053.GD2041@work-vm> (raw)
In-Reply-To: <0eb0b7ef-7bc7-70f0-7d6d-4d9ff565775d@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
>
>
> On 05/09/2016 20:50, Dr. David Alan Gilbert wrote:
> > * Paolo Bonzini (pbonzini@redhat.com) wrote:
> >>
> >>
> >> On 25/08/2016 11:37, Dr. David Alan Gilbert (git) wrote:
> >>>
> >>> (qemu) qom-get /backend/console[0]/device/vga.rom[0] size
> >>> 65536 (0x10000)
> >>>
> >>> (qemu) qom-get /machine smm
> >>> "auto"
> >>>
> >>> (qemu) qom-get /machine rtc-time
> >>> struct type not implemented
> >>
> >> Looks nice. Perhaps instead of using the "human" interface we could
> >> just print it as JSON and avoid the error.
> >
> > I can't see a sane place to glue a fallback to the JSON code in;
> > or do you mean use the JSON output even in the simple case?
>
> Yeah. I think it makes sense for a low level command such as qom-get.
> All that you lose is the automatic hex conversion in the first example.
Hmm yes, it does - v2 coming up.
Dave
>
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2016-09-06 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 9:37 [Qemu-devel] [PATCH 0/2] qom-get [for 2.8] Dr. David Alan Gilbert (git)
2016-08-25 9:37 ` [Qemu-devel] [PATCH 1/2] qapi: Stub out StringOutputVisitor struct support Dr. David Alan Gilbert (git)
2016-09-19 13:11 ` Markus Armbruster
2016-09-19 13:47 ` Dr. David Alan Gilbert
2016-09-19 14:14 ` Markus Armbruster
2016-09-19 14:21 ` Dr. David Alan Gilbert
2016-09-19 15:27 ` Markus Armbruster
2016-09-19 15:38 ` Dr. David Alan Gilbert
2016-09-19 16:52 ` Markus Armbruster
2016-09-19 17:39 ` Dr. David Alan Gilbert
2016-08-25 9:37 ` [Qemu-devel] [PATCH 2/2] qom: Implement qom-get HMP command Dr. David Alan Gilbert (git)
2016-09-19 13:30 ` Markus Armbruster
2016-08-30 10:59 ` [Qemu-devel] [PATCH 0/2] qom-get [for 2.8] Paolo Bonzini
2016-09-05 18:50 ` Dr. David Alan Gilbert
2016-09-06 7:22 ` Paolo Bonzini
2016-09-06 10:10 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906101053.GD2041@work-vm \
--to=dgilbert@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).