From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDLL-0002SX-8C for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhDLH-0007zA-0C for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:11:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDLG-0007z4-Qe for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:10:58 -0400 Date: Tue, 6 Sep 2016 11:10:53 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160906101053.GD2041@work-vm> References: <1472117833-10236-1-git-send-email-dgilbert@redhat.com> <5d53e70e-09ca-6e57-92a8-e79f520c3834@redhat.com> <20160905185038.GI22496@work-vm> <0eb0b7ef-7bc7-70f0-7d6d-4d9ff565775d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eb0b7ef-7bc7-70f0-7d6d-4d9ff565775d@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] qom-get [for 2.8] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, arei.gonglei@huawei.com, kwolf@redhat.com * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 05/09/2016 20:50, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonzini@redhat.com) wrote: > >> > >> > >> On 25/08/2016 11:37, Dr. David Alan Gilbert (git) wrote: > >>> > >>> (qemu) qom-get /backend/console[0]/device/vga.rom[0] size > >>> 65536 (0x10000) > >>> > >>> (qemu) qom-get /machine smm > >>> "auto" > >>> > >>> (qemu) qom-get /machine rtc-time > >>> struct type not implemented > >> > >> Looks nice. Perhaps instead of using the "human" interface we could > >> just print it as JSON and avoid the error. > > > > I can't see a sane place to glue a fallback to the JSON code in; > > or do you mean use the JSON output even in the simple case? > > Yeah. I think it makes sense for a low level command such as qom-get. > All that you lose is the automatic hex conversion in the first example. Hmm yes, it does - v2 coming up. Dave > > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK