Re: [Qemu-devel] [PATCH v3 0/2] tests: add RTAS protocol

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 0/2] tests: add RTAS protocol
Type: series
Message-id: 1473160625-6377-1-git-send-email-lvivier@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1473160625-6377-1-git-send-email-lvivier@redhat.com -> patchew/1473160625-6377-1-git-send-email-lvivier@redhat.com
Switched to a new branch 'test'
2acbc73 tests: add RTAS command in the protocol
ba5d51c tests: make pc_alloc_init/init_flags/uninit generic

=== OUTPUT BEGIN ===
Checking PATCH 1/2: tests: make pc_alloc_init/init_flags/uninit generic...
Checking PATCH 2/2: tests: add RTAS command in the protocol...
ERROR: consider using qemu_strtol in preference to strtol
#90: FILE: qtest.c:539:
+        nargs = strtol(words[2], NULL, 0);

ERROR: consider using qemu_strtoll in preference to strtoll
#91: FILE: qtest.c:540:
+        args = strtoll(words[3], NULL, 0);

ERROR: consider using qemu_strtol in preference to strtol
#92: FILE: qtest.c:541:
+        nret = strtol(words[4], NULL, 0);

ERROR: consider using qemu_strtoll in preference to strtoll
#93: FILE: qtest.c:542:
+        ret = strtoll(words[5], NULL, 0);

total: 4 errors, 0 warnings, 252 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org