From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhFCE-0007aK-DT for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhFC9-0006Xt-7Y for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:09:45 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:5799 helo=imgpgp01.kl.imgtec.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhFC8-0006Xc-US for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:09:41 -0400 Date: Tue, 6 Sep 2016 13:09:37 +0100 From: James Hogan Message-ID: <20160906120937.GA1196@jhogan-linux.le.imgtec.org> References: <20160906111834.76033.11400@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline In-Reply-To: <20160906111834.76033.11400@ex-std-node742.prod.rhcloud.com> Subject: Re: [Qemu-devel] [PATCH 0/9] target-mips: Add Enhanced Virtual Addressing (EVA) support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 06, 2016 at 04:18:38AM -0700, no-reply@patchew.org wrote: > Checking PATCH 1/9: target-mips: Add CP0_Ebase.WG (write gate) support... > ERROR: space prohibited after that '&' (ctx:WxW) > #104: FILE: target-mips/op_helper.c:1529: > + if (arg1 & (1 << CP0EBase_WG) & env->CP0_EBase_rw_bitmask) { > ^ >=20 > ERROR: space prohibited after that '&' (ctx:WxW) > #116: FILE: target-mips/op_helper.c:1540: > + if (arg1 & (1 << CP0EBase_WG) & env->CP0_EBase_rw_bitmask) { > ^ its a bitwise and operator, not an address-of operator, so I presumed this was a false positive. > Checking PATCH 6/9: target-mips: Add an MMU mode for ERL... > ERROR: trailing statements should be on next line > #94: FILE: target-mips/op_helper.c:97: > + case 3: cpu_##insn##_error_ra(env, addr, val, retaddr); break; \ And this is merely consistent with the surrounding lines so I didn't bother fixing it. Cheers James --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXzrIBAAoJEGwLaZPeOHZ6u6QP/iudYZJtSfZ4X1rQguJw6Cl+ L/GcroMdOq7xgHtkJVq3LHQ6xkntSPOwzYZjHZsX/lemnrf5c1tVQ6YBNWlgIi2c o332jcJo831yB36mzICqvYIZ2cKmtPTT0nN51jDUpyHhOyYUKLaBeII4UOWElWCh FHapqoefspRmXqf0JpIpwDw894ItCMsUDtZQrybsDau4FWVzPsQDGo4qwGV1ToTx TZ1E7GiCOeEA5hZUeLMd0mlL7YzVA2nP1a49yHfMDSdIp9o4Cdnv3KjPQIbi2/tX lwOrc+S6169DOuvuW62rgvyNJnqu9soGZ3w1gAyyBzxv+Ds5ERdpLpksQDyYHOwg /glm0j8z9cXbp7VYmnKK0ij0Jvg+sRrIc3lzqs4l5Nrss4/gQMuHvyj1HMHPPl6H Kl72s8GT5LT9E9p3YO+jYAj4aQWIbXO4JOxnipfFCUZ6ONvMh7+L9KZ0boSe4iCq bAgYE1hRg61q0A657YgTWYIJT98UHkBt4rhnJDRVBg8r+9GAvPr+TZBKyWYPd0eh xNzWLdV0YGzFhp29SJKom//i57Ohf9StW+ScYN/3ifB3zJqIH9yemq9ma5OrG4y1 C5b3NHKTaFQ9WXQGHr3jyRXUjZKH9GTQ3OYgjdpGfE3f2E88wl/CShXOePMdAr7H T+/GPPNH7bFjsZZscRea =pxLP -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy--