From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bhJ50-0004ET-5x
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 12:18:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bhJ4y-0008K4-4g
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 12:18:33 -0400
Date: Tue, 6 Sep 2016 18:18:22 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160906161822.GG4667@noname.redhat.com>
References: <1470662013-19785-1-git-send-email-famz@redhat.com>
	<1470662013-19785-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470662013-19785-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 02/20] qapi: Add lock-mode in
 blockdev-add options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, rjones@redhat.com, John Snow <jsnow@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com, berrange@redhat.com

Am 08.08.2016 um 15:13 hat Fam Zheng geschrieben:
> To allow overriding the default locking behavior when opening the image.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  qapi/block-core.json | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 5e2d7d7..d1eb197 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2151,6 +2151,20 @@
>              '*debug-level': 'int' } }
>  
>  ##
> +# @BlockdevLockMode
> +#
> +# Describes how QEMU should lock the image.
> +#
> +# @off:       Disabled
> +# @shared:    Use shared lock for both RO and RW images.
> +# @auto:      Use exclusive lock for RW images, and shared lock for RO images.
> +#
> +# Since: 2.7
> +##
> +{ 'enum': 'BlockdevLockMode',
> +  'data': [ 'off', 'shared', 'auto' ] }

You decided to drop 'exclusive'? Didn't we agree last time that we
should have both a real 'exclusive' and 'auto'?

Kevin