From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHgh-00088U-Me for qemu-devel@nongnu.org; Tue, 06 Sep 2016 10:49:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhHge-0002we-Du for qemu-devel@nongnu.org; Tue, 06 Sep 2016 10:49:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhHge-0002w7-5K for qemu-devel@nongnu.org; Tue, 06 Sep 2016 10:49:20 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u86EmXrm063173 for ; Tue, 6 Sep 2016 10:49:16 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 259d2sgygm-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Sep 2016 10:49:16 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Sep 2016 15:49:14 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id F057817D8069 for ; Tue, 6 Sep 2016 15:51:02 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u86EnAvE25166270 for ; Tue, 6 Sep 2016 14:49:10 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u86EnAgg007250 for ; Tue, 6 Sep 2016 10:49:10 -0400 Date: Tue, 6 Sep 2016 16:49:08 +0200 From: Cornelia Huck In-Reply-To: References: <20160906074710.13495-1-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160906164908.24492fe4.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 00/38] First set of s390x patches for 2.8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Christian Borntraeger , Alexander Graf , Jens Freimann , QEMU Developers , David Hildenbrand On Tue, 6 Sep 2016 15:32:26 +0100 Peter Maydell wrote: > On 6 September 2016 at 08:46, Cornelia Huck wrote: > > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > > > are available in the git repository at: > > > > git://github.com/cohuck/qemu tags/s390x-20160906 > > > > for you to fetch changes up to f216f2122519e24f57e09103ea5beb4c43f241c0: > > > > s390x/cpumodel: implement QMP interface "query-cpu-model-baseline" (2016-09-05 15:49:23 +0200) > > > > ---------------------------------------------------------------- > > First (big) chunk of s390x updates: > > - cpumodel support for s390x > > - various fixes and improvements > > > > ---------------------------------------------------------------- > > Hi; I'm afraid this causes compile warnings with clang, which look > like they're flagging up a genuine bug: > > CC ppc-softmmu/migration/savevm.o > /Users/pm215/src/qemu-for-merges/target-s390x/cpu_models.c:254:11: > warning: explicitly assigning value of variable of type 'FILE *' (aka > 'struct __sFILE *') to itself [-Wself-assign] > f = f, > ~ ^ ~ > /Users/pm215/src/qemu-for-merges/target-s390x/cpu_models.c:255:15: > warning: explicitly assigning value of variable of type > 'fprintf_function' (aka 'int (*)(FILE *, const char *, ...)') to > itself [-Wself-assign] > print = print, > ~~~~~ ^ ~~~~~ > 2 warnings generated. > > Looks like you forgot the '.' on the front of the field > names in the structure initializer. Ugh, yes. Looks trivial enough to fix up: I'll probably just do that and send a v2.