From: David Gibson <david@gibson.dropbear.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, alex.bennee@linaro.org, rth@twiddle.net,
qemu-devel@nongnu.org, benh@kernel.crashing.org
Subject: Re: [Qemu-devel] [PATCH RFC 2/4] target-ppc: with MTTCG report more threads
Date: Wed, 7 Sep 2016 13:51:33 +1000 [thread overview]
Message-ID: <20160907035133.GI2780@voom.fritz.box> (raw)
In-Reply-To: <1472797976-24210-3-git-send-email-nikunj@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
On Fri, Sep 02, 2016 at 12:02:54PM +0530, Nikunj A Dadhania wrote:
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
> target-ppc/kvm.c | 2 +-
> target-ppc/kvm_ppc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index dcb68b9..20eb450 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -2090,7 +2090,7 @@ void kvmppc_set_mpic_proxy(PowerPCCPU *cpu, int mpic_proxy)
>
> int kvmppc_smt_threads(void)
> {
> - return cap_ppc_smt ? cap_ppc_smt : 1;
> + return cap_ppc_smt ? cap_ppc_smt : 8;
> }
>
> #ifdef TARGET_PPC64
> diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
> index 5461d10..053db0a 100644
> --- a/target-ppc/kvm_ppc.h
> +++ b/target-ppc/kvm_ppc.h
> @@ -128,7 +128,7 @@ static inline void kvmppc_set_mpic_proxy(PowerPCCPU *cpu, int mpic_proxy)
>
> static inline int kvmppc_smt_threads(void)
> {
> - return 1;
> + return 8;
> }
>
> static inline int kvmppc_or_tsr_bits(PowerPCCPU *cpu, uint32_t tsr_bits)
This doesn't make sense to me. Allowing multiple hardware threads to
be emulated in TCG (which I think will require a bunch of fixes) seems
like a separate question to MTTCG - i.e. allowing separate vcpus to be
TCG emulated in separate host threads.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-07 4:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 6:32 [Qemu-devel] [PATCH RFC 0/4] Enable MTTCG on PowerPC Nikunj A Dadhania
2016-09-02 6:32 ` [Qemu-devel] [PATCH RFC 1/4] spapr-hcall: take iothread lock during handler call Nikunj A Dadhania
2016-09-02 8:53 ` Greg Kurz
2016-09-02 9:28 ` Nikunj A Dadhania
2016-09-02 9:57 ` Greg Kurz
2016-09-03 16:31 ` Nikunj A Dadhania
2016-09-02 10:06 ` Thomas Huth
2016-09-03 16:33 ` Nikunj A Dadhania
2016-09-02 6:32 ` [Qemu-devel] [PATCH RFC 2/4] target-ppc: with MTTCG report more threads Nikunj A Dadhania
2016-09-02 9:28 ` Greg Kurz
2016-09-02 9:34 ` Nikunj A Dadhania
2016-09-02 10:45 ` Greg Kurz
2016-09-03 16:34 ` Nikunj A Dadhania
2016-09-07 3:51 ` David Gibson [this message]
2016-09-07 4:41 ` Nikunj A Dadhania
2016-09-02 6:32 ` [Qemu-devel] [PATCH RFC 3/4] target-ppc: use atomic_cmpxchg for ld/st reservation Nikunj A Dadhania
2016-09-07 4:02 ` David Gibson
2016-09-07 4:47 ` Nikunj A Dadhania
2016-09-07 5:24 ` Benjamin Herrenschmidt
2016-09-07 8:42 ` Nikunj A Dadhania
2016-09-07 5:34 ` David Gibson
2016-09-07 7:13 ` Alex Bennée
2016-09-12 1:19 ` David Gibson
2016-09-12 8:39 ` Alex Bennée
2016-09-12 9:15 ` Benjamin Herrenschmidt
2016-09-02 6:32 ` [Qemu-devel] [PATCH RFC 4/4] target-ppc: flush tlb from all the cpu Nikunj A Dadhania
2016-09-02 7:22 ` Benjamin Herrenschmidt
2016-09-02 7:34 ` Nikunj A Dadhania
2016-09-04 17:00 ` Alex Bennée
2016-09-04 22:17 ` Benjamin Herrenschmidt
2016-09-05 0:10 ` Benjamin Herrenschmidt
2016-09-06 1:55 ` Nikunj A Dadhania
2016-09-06 3:05 ` Benjamin Herrenschmidt
2016-09-06 4:53 ` Nikunj A Dadhania
2016-09-06 5:30 ` Benjamin Herrenschmidt
2016-09-06 6:57 ` Nikunj A Dadhania
2016-09-02 6:43 ` [Qemu-devel] [PATCH RFC 0/4] Enable MTTCG on PowerPC Cédric Le Goater
2016-09-02 6:46 ` Nikunj A Dadhania
2016-09-02 7:57 ` Thomas Huth
2016-09-02 11:44 ` Cédric Le Goater
2016-09-02 7:19 ` Benjamin Herrenschmidt
2016-09-02 7:39 ` Nikunj A Dadhania
2016-09-02 12:13 ` Benjamin Herrenschmidt
2016-09-07 4:08 ` David Gibson
2016-09-07 4:48 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907035133.GI2780@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.bennee@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).