From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhU8H-00026U-8d for qemu-devel@nongnu.org; Wed, 07 Sep 2016 00:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhU8F-0004vZ-2n for qemu-devel@nongnu.org; Wed, 07 Sep 2016 00:06:40 -0400 Date: Wed, 7 Sep 2016 13:51:33 +1000 From: David Gibson Message-ID: <20160907035133.GI2780@voom.fritz.box> References: <1472797976-24210-1-git-send-email-nikunj@linux.vnet.ibm.com> <1472797976-24210-3-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YrQNB5Deg1WGKZi3" Content-Disposition: inline In-Reply-To: <1472797976-24210-3-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC 2/4] target-ppc: with MTTCG report more threads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, alex.bennee@linaro.org, rth@twiddle.net, qemu-devel@nongnu.org, benh@kernel.crashing.org --YrQNB5Deg1WGKZi3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2016 at 12:02:54PM +0530, Nikunj A Dadhania wrote: > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/kvm.c | 2 +- > target-ppc/kvm_ppc.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index dcb68b9..20eb450 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -2090,7 +2090,7 @@ void kvmppc_set_mpic_proxy(PowerPCCPU *cpu, int mpi= c_proxy) > =20 > int kvmppc_smt_threads(void) > { > - return cap_ppc_smt ? cap_ppc_smt : 1; > + return cap_ppc_smt ? cap_ppc_smt : 8; > } > =20 > #ifdef TARGET_PPC64 > diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h > index 5461d10..053db0a 100644 > --- a/target-ppc/kvm_ppc.h > +++ b/target-ppc/kvm_ppc.h > @@ -128,7 +128,7 @@ static inline void kvmppc_set_mpic_proxy(PowerPCCPU *= cpu, int mpic_proxy) > =20 > static inline int kvmppc_smt_threads(void) > { > - return 1; > + return 8; > } > =20 > static inline int kvmppc_or_tsr_bits(PowerPCCPU *cpu, uint32_t tsr_bits) This doesn't make sense to me. Allowing multiple hardware threads to be emulated in TCG (which I think will require a bunch of fixes) seems like a separate question to MTTCG - i.e. allowing separate vcpus to be TCG emulated in separate host threads. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --YrQNB5Deg1WGKZi3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJXz47FAAoJEGw4ysog2bOSZeEP+gLO4nlzJjJ75VcjFMZnSDnJ waGLccQVFFdmOPijtyh54c9acmdzg+SJnHnwxhdWkO3JrujzGzj7I5uQdZSA+vYg hp04ZzkoUd8NbwPPCo5i+CJ5mx6wZT1SNlLgEpOEvkVLCZY0Ns2KP5vbYEEcnlhE zhg0F6bB7N2izz2y60k8+dA5D9flevwPisxT9Q9+aw9xw8S2FGJbhwJZX5QPg+8m su89TIL6XXy/ddYl3G5ab9B/uccQyTxQ3vwGGDAkyiLem1ECscMlb5sPonkrnciz tuBl9mtaEyp8uza3y9cwXlKTkLzkf6xDYG5tROm0tcT4ntK6Z+87aKBRmQTLNeLq JS+Nb8OgkX/SJUFfbIo7RajSmGBaYrjjLlLHegP2SIeRA32ONd/xHHJx+4qd0jgK PZSNX1cNnicR+X5C1dpGp/uxPZkSTOSYo4xwlNM8o9eeezeZ1dIkkqvZfTo+61On MN3eByrS4AHR5tK+7dHQuu8X4yFl1t7z3vwfP6M0LKagnp/MWD+3wO2fdN7F1mw1 7hClTFtdG0vfAaQ2TmeAhaFmDJVgzcU7szF0QyVY1irEuvj9+DZNt8pfDZTWWLoj 9h0v+tXtZqVcZdn68GH/Iwlm/oLWkolecv7KyueHZeNzFHrObEEJuUr36qVG2HfW 76LhlcNbfIJPA5nXq4ql =/OSd -----END PGP SIGNATURE----- --YrQNB5Deg1WGKZi3--