From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhcD9-0003rE-0H for qemu-devel@nongnu.org; Wed, 07 Sep 2016 08:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhcD4-00076n-TO for qemu-devel@nongnu.org; Wed, 07 Sep 2016 08:44:14 -0400 Received: from 19.mo1.mail-out.ovh.net ([178.32.97.206]:57826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhcD4-00076b-O8 for qemu-devel@nongnu.org; Wed, 07 Sep 2016 08:44:10 -0400 Received: from player726.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id 458AFFF8B42 for ; Wed, 7 Sep 2016 14:44:08 +0200 (CEST) Date: Wed, 7 Sep 2016 14:44:00 +0200 From: Greg Kurz Message-ID: <20160907144400.6bcf59a0@bahia> In-Reply-To: <8e76a3be-cea1-d788-3f1d-045e896a6876@redhat.com> References: <1473167877-2545-1-git-send-email-lvivier@redhat.com> <1473167877-2545-3-git-send-email-lvivier@redhat.com> <20160906234111.02181f40@bahia> <8e76a3be-cea1-d788-3f1d-045e896a6876@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: david@gibson.dropbear.id.au, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, 7 Sep 2016 11:36:21 +0200 Laurent Vivier wrote: > On 06/09/2016 23:41, Greg Kurz wrote: > > On Tue, 6 Sep 2016 15:17:56 +0200 > > Laurent Vivier wrote: > > > >> And add support for ppc64. > >> > >> Signed-off-by: Laurent Vivier > >> --- > >> v2: > >> - remove useless parenthesis, inline > >> > > > > This works indeed but I'm just feeling curious about the QOSOps type introduced > > by the following commit: > > > > commit 90e5add6f2fa0b0bd9a4c1d5a4de2304b5f3e466 > > Author: John Snow > > Date: Mon Jan 19 15:15:55 2015 -0500 > > > > libqos: add pc specific interface > > > > Wouldn't this be better to implement something similar for ppc64 instead of > > relying on strcmp() ? > > Tests can be generic and to be run on several archs: we need the > strcmp() to check the guest arch [1], it can't be hardcoded in the test. > I agree for truely platform agnostic tests, but this is obviously not the case for RTAS, which is the goal of this series. My suggestion is basically to: - keep malloc-ppc64.[ch] from your series - introduce libqos-ppc64.[ch] like the existing libqos-pc.[ch] - add qtest_ppc64_[start|end]() wrappers to pass global_qtest to qtest_ppc64_[boot|shutdown]() - adapt the final RTAS test patch to use these wrappers and q[malloc|free]() BTW, maybe s/ppc64/ppc to match hw/ppc, since libqos is about HW platforms, not target archs. This is more work, but I guess in the end it maybe useful in the long term. And, of course, I'm volunteering to participate, with patches/reviewing/testing. Makes sense ? Cheers. -- Greg > Thanks, > Laurent > > [1] > const char *qtest_get_arch(void) > { > const char *qemu = getenv("QTEST_QEMU_BINARY"); > g_assert(qemu != NULL); > const char *end = strrchr(qemu, '/'); > > return end + strlen("/qemu-system-"); > }