From: Stefan Hajnoczi <stefanha@redhat.com>
To: Ladi Prosek <lprosek@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, rkagan@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: stats vq fixes
Date: Wed, 7 Sep 2016 14:02:15 -0400 [thread overview]
Message-ID: <20160907180215.GC18576@stefanha-x1.localdomain> (raw)
In-Reply-To: <1473261649-31465-1-git-send-email-lprosek@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Wed, Sep 07, 2016 at 05:20:46PM +0200, Ladi Prosek wrote:
> It is not
> necessary to check balloon_stats_supported. Pushing buffers without
> negotiating stats support would be a driver bug. The common codepath
> does not check it either.
This part made me nervous because QEMU is never allowed to trust the
guest - QEMU must never crash or expose information to the guest.
However this seems okay since virtqueue_rewind() on an unused virtqueue
is safe. It will return false so we'll never actually try to access a
virtqueue that hasn't been initialized.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-09-07 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:20 [Qemu-devel] [PATCH 0/3] virtio-balloon: stats vq fixes Ladi Prosek
2016-09-07 15:20 ` [Qemu-devel] [PATCH 1/3] virtio-balloon: discard virtqueue element on reset Ladi Prosek
2016-09-07 17:48 ` Stefan Hajnoczi
2016-09-08 6:38 ` Roman Kagan
2016-09-07 15:20 ` [Qemu-devel] [PATCH 2/3] virtio: add virtqueue_rewind() Ladi Prosek
2016-09-08 6:44 ` Roman Kagan
2016-09-08 7:30 ` Ladi Prosek
2016-09-12 9:20 ` Stefan Hajnoczi
2016-09-07 15:20 ` [Qemu-devel] [PATCH 3/3] virtio-balloon: fix stats vq migration Ladi Prosek
2016-09-07 18:02 ` Stefan Hajnoczi
2016-09-08 6:47 ` Roman Kagan
2016-09-07 18:02 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907180215.GC18576@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=lprosek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).