From: Kevin Wolf <kwolf@redhat.com>
To: ashish mittal <ashmit602@gmail.com>
Cc: Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Ashish Mittal <ashish.mittal@veritas.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com
Subject: Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support
Date: Thu, 8 Sep 2016 10:43:19 +0200 [thread overview]
Message-ID: <20160908084319.GA4206@noname.redhat.com> (raw)
In-Reply-To: <CAAo6VWOnrcVwR0XEsZOnmjrr2wup3+kLh4UQUuxXq4zZzrVZBw@mail.gmail.com>
Am 08.09.2016 um 00:32 hat ashish mittal geschrieben:
> >> +
> >> +void vxhs_set_acb_buffer(void *ptr, void *buffer)
> >> +{
> >> + VXHSAIOCB *acb = ptr;
> >> +
> >> + acb->buffer = buffer;
> >> +}
> >> +
> >
> > Unused function?
>
> This is called from within libqnio.
Wait, you mean the library references a symbol in the qemu binary? This
sounds completely wrong to me. I wouldn't even do something like this if
it were an internal qemu library because I think libraries should be
self-contained, but it's a much larger problem in something that is
supposed to be an independent library.
If the library has to call into qemu, it should only do so through
callbacks that qemu registered with the library (and then the function
wouldn't look unused in qemu).
In an earlier version of the series I suggested moving the part directly
related to qemu (at least the functions called qemu_*) from the library
to the block driver. Did you consider this?
Kevin
next prev parent reply other threads:[~2016-09-08 8:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:56 [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support Ashish Mittal
2016-08-30 17:35 ` Jeff Cody
2016-09-07 22:32 ` ashish mittal
2016-09-08 8:43 ` Kevin Wolf [this message]
2016-09-08 8:49 ` Daniel P. Berrange
2016-09-08 9:29 ` Kevin Wolf
2016-09-08 9:34 ` Daniel P. Berrange
2016-09-08 12:48 ` Jeff Cody
2016-09-08 9:43 ` Daniel P. Berrange
2016-09-08 10:18 ` Kevin Wolf
2016-09-08 10:23 ` Paolo Bonzini
2016-09-08 14:00 ` Jeff Cody
2016-09-08 14:20 ` [Qemu-devel] vxhs caching behaviour (was: [PATCH v4 RFC] block/vxhs: Initial commit to add) " Kevin Wolf
2016-09-08 20:46 ` ashish mittal
2016-09-09 10:38 ` Kevin Wolf
2016-09-08 23:15 ` [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add " ashish mittal
2016-09-21 6:39 ` ashish mittal
2016-09-06 10:09 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908084319.GA4206@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=Abhijit.Dey@veritas.com \
--cc=Ketan.Nilangekar@veritas.com \
--cc=armbru@redhat.com \
--cc=ashish.mittal@veritas.com \
--cc=ashmit602@gmail.com \
--cc=berrange@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).