qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: groug@kaod.org
Cc: famz@redhat.com, qemu-devel@nongnu.org,
	aneesh.kumar@linux.vnet.ibm.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p
Date: Fri, 9 Sep 2016 01:10:51 -0700 (PDT)	[thread overview]
Message-ID: <20160909081048.76033.70302@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <147340827736.6462.8546871953640244651.stgit@bahia>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 147340827736.6462.8546871953640244651.stgit@bahia
Subject: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/147340827736.6462.8546871953640244651.stgit@bahia -> patchew/147340827736.6462.8546871953640244651.stgit@bahia
Switched to a new branch 'test'
04c0f1e tests: virtio-9p: add basic transaction test
5194780 tests: virtio-9p: add basic configuration test
e762ebb tests: virtio-9p: introduce start/stop functions

=== OUTPUT BEGIN ===
Checking PATCH 1/3: tests: virtio-9p: introduce start/stop functions...
Checking PATCH 2/3: tests: virtio-9p: add basic configuration test...
ERROR: "foo* bar" should be "foo *bar"
#105: FILE: tests/virtio-9p-test.c:97:
+    char* tag;

total: 1 errors, 0 warnings, 113 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: tests: virtio-9p: add basic transaction test...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2016-09-09  8:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  8:04 [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 1/3] tests: virtio-9p: introduce start/stop functions Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 2/3] tests: virtio-9p: add basic configuration test Greg Kurz
2016-09-15  8:40   ` Cornelia Huck
2016-09-15 12:09     ` Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 3/3] tests: virtio-9p: add basic transaction test Greg Kurz
2016-09-09  8:10 ` no-reply [this message]
2016-09-15  7:45 ` [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p Greg Kurz
2016-09-15  8:41 ` Cornelia Huck
2016-09-15 12:45   ` Greg Kurz
2016-09-15 13:04     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909081048.76033.70302@ex-std-node742.prod.rhcloud.com \
    --to=no-reply@patchew.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=famz@redhat.com \
    --cc=groug@kaod.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).