From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1biKsW-0004o9-TD
	for qemu-devel@nongnu.org; Fri, 09 Sep 2016 08:25:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1biKsS-0000Vy-Qy
	for qemu-devel@nongnu.org; Fri, 09 Sep 2016 08:25:55 -0400
Received: from 10.mo68.mail-out.ovh.net ([46.105.79.203]:57025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1biKsS-0000VW-L2
	for qemu-devel@nongnu.org; Fri, 09 Sep 2016 08:25:52 -0400
Received: from player778.ha.ovh.net (b7.ovh.net [213.186.33.57])
	by mo68.mail-out.ovh.net (Postfix) with ESMTP id 83166FF9E84
	for <qemu-devel@nongnu.org>; Fri,  9 Sep 2016 14:25:51 +0200 (CEST)
Date: Fri, 9 Sep 2016 14:25:45 +0200
From: Greg Kurz <groug@kaod.org>
Message-ID: <20160909142545.4876b85e@bahia>
In-Reply-To: <19b24b76-5650-74de-6870-f6a8bc3f5e12@redhat.com>
References: <1473167877-2545-1-git-send-email-lvivier@redhat.com>
	<1473167877-2545-3-git-send-email-lvivier@redhat.com>
	<20160908020423.GD3883@voom.fritz.box>
	<19b24b76-5650-74de-6870-f6a8bc3f5e12@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make
 pc_alloc_init/init_flags/uninit generic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <lvivier@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On Thu, 8 Sep 2016 09:50:31 +0200
Laurent Vivier <lvivier@redhat.com> wrote:

> On 08/09/2016 04:04, David Gibson wrote:
> > On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote:  
> >> And add support for ppc64.
> >>
> >> Signed-off-by: Laurent Vivier <lvivier@redhat.com>  
> > 
> > Some of my coments may be obsoleted by the discussion with Greg.
> >   
> >> ---
> >> v2:
> >> - remove useless parenthesis, inline
> [...]
> >> +
> >> +QGuestAllocator *machine_alloc_init(void)
> >> +{
> >> +    const char *arch = qtest_get_arch();  
> > 
> > Maybe we need to add a qtest_get_machine_type().  
> 
> I'm working on that...
> 

The problem is that qtest only knows about archs, based on $(TARGETS).
Maybe the machine type could be the default one for a given arch ?

Cheers.

--
Greg