From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjPAw-0001Sp-OQ for qemu-devel@nongnu.org; Mon, 12 Sep 2016 07:13:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjPAs-0007WD-Hw for qemu-devel@nongnu.org; Mon, 12 Sep 2016 07:13:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjPAs-0007W7-Cc for qemu-devel@nongnu.org; Mon, 12 Sep 2016 07:13:18 -0400 Date: Mon, 12 Sep 2016 19:13:12 +0800 From: Peter Xu Message-ID: <20160912111311.GG3776@pxdev.xzpeter.org> References: <1473674889-2727-1-git-send-email-davidkiarie4@gmail.com> <1473674889-2727-3-git-send-email-davidkiarie4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1473674889-2727-3-git-send-email-davidkiarie4@gmail.com> Subject: Re: [Qemu-devel] [v4 2/6] hw/i386: enforce SID verification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie Cc: qemu-devel@nongnu.org, jan.kiszka@web.de, mst@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote: > Platform devices are now able to make interrupt request with > explicit SIDs hence we can safely expect triggered AddressSpace ID > to match the requesting ID > > Signed-off-by: David Kiarie > --- > hw/i386/intel_iommu.c | 77 ++++++++++++++++++++++++++------------------------- > 1 file changed, 39 insertions(+), 38 deletions(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 496d836..e4bad6a 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2043,43 +2043,41 @@ static int vtd_irte_get(IntelIOMMUState *iommu, uint16_t index, > return -VTD_FR_IR_IRTE_RSVD; > } > > - if (sid != X86_IOMMU_SID_INVALID) { Btw, if we removed all references of X86_IOMMU_SID_INVALID, we can just remove the defination as well in this patch. Thanks, -- peterx