From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVAm-0007Yy-UI for qemu-devel@nongnu.org; Mon, 12 Sep 2016 13:37:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjVAh-0007a5-Te for qemu-devel@nongnu.org; Mon, 12 Sep 2016 13:37:35 -0400 Received: from 2.mo68.mail-out.ovh.net ([46.105.52.162]:40477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVAh-0007Zg-No for qemu-devel@nongnu.org; Mon, 12 Sep 2016 13:37:31 -0400 Received: from player778.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id C4F76FF960D for ; Mon, 12 Sep 2016 19:37:30 +0200 (CEST) Date: Mon, 12 Sep 2016 19:37:23 +0200 From: Greg Kurz Message-ID: <20160912193723.0646a806@bahia> In-Reply-To: <06c5d8e7-b231-c2b7-0bb0-f13cd268c04b@redhat.com> References: <1473167877-2545-1-git-send-email-lvivier@redhat.com> <1473167877-2545-3-git-send-email-lvivier@redhat.com> <20160908020423.GD3883@voom.fritz.box> <19b24b76-5650-74de-6870-f6a8bc3f5e12@redhat.com> <20160909142545.4876b85e@bahia> <20160912012757.GE12621@voom.fritz.box> <06c5d8e7-b231-c2b7-0bb0-f13cd268c04b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: David Gibson , thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Mon, 12 Sep 2016 17:46:35 +0200 Laurent Vivier wrote: > On 12/09/2016 03:27, David Gibson wrote: > > On Fri, Sep 09, 2016 at 02:31:55PM +0200, Laurent Vivier wrote: > >> > >> > >> On 09/09/2016 14:25, Greg Kurz wrote: > >>> On Thu, 8 Sep 2016 09:50:31 +0200 > >>> Laurent Vivier wrote: > >>> > >>>> On 08/09/2016 04:04, David Gibson wrote: > >>>>> On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote: > >>>>>> And add support for ppc64. > >>>>>> > >>>>>> Signed-off-by: Laurent Vivier > >>>>> > >>>>> Some of my coments may be obsoleted by the discussion with Greg. > >>>>> > >>>>>> --- > >>>>>> v2: > >>>>>> - remove useless parenthesis, inline > >>>> [...] > >>>>>> + > >>>>>> +QGuestAllocator *machine_alloc_init(void) > >>>>>> +{ > >>>>>> + const char *arch = qtest_get_arch(); > >>>>> > >>>>> Maybe we need to add a qtest_get_machine_type(). > >>>> > >>>> I'm working on that... > >>>> > >>> > >>> The problem is that qtest only knows about archs, based on $(TARGETS). > >>> Maybe the machine type could be the default one for a given arch ? > >> > >> Once the machine is started we can use QMP[1] to ask the machine type > >> (for instance, "pseries-2.7-machine"). > >> > >> So what we could do is a generic qtest_machine_vboot() which ask the > >> machine type and configure the qtest framework accordingly. > >> > >> Laurent > >> [1] { 'execute': 'qom-get', 'arguments': { 'path': '/machine', > >> 'property': 'type' } } > > > > Ok.. doesn't the qtest framework start the machine though? So it > > should already know the machine type, shouldn't it? > > In fact qtest starts the machine with the content of QTEST_QEMU_BINARY > and we don't provide "-machine" parameter, so it doesn't know the > machine type. It can guess it according to the machine arch, and by > default, ppc64 (arch) is pseries (machine). > > Perhaps we can add "-machine pseries" in qtest_spapr_vboot(). > We may want to test something that is only available for a given version (like CPU hotplug for pseries >= 2.7 for example)... it could *work* if we can pass "-machine pseries -machine pseries-2.7" and the latter prevails, but that looks a bit like a hack. Cheers. -- Greg > Laurent > Laurent