From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjUVC-0006Ve-A4 for qemu-devel@nongnu.org; Mon, 12 Sep 2016 12:54:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjUV6-00059j-C4 for qemu-devel@nongnu.org; Mon, 12 Sep 2016 12:54:37 -0400 Date: Mon, 12 Sep 2016 19:54:29 +0300 From: "Michael S. Tsirkin" Message-ID: <20160912195401-mutt-send-email-mst@kernel.org> References: <1473426607-10516-1-git-send-email-maxime.coquelin@redhat.com> <1473426607-10516-2-git-send-email-maxime.coquelin@redhat.com> <20160912142815.7bf7cc5c.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 1/2] virtio: Add function to check whether backend supports VIRTIO_1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: Cornelia Huck , qemu-devel@nongnu.org, marcel@redhat.com, vkaplans@redhat.com, qemu-stable@nongnu.org On Mon, Sep 12, 2016 at 06:42:46PM +0200, Maxime Coquelin wrote: > > > On 09/12/2016 02:28 PM, Cornelia Huck wrote: > > On Fri, 9 Sep 2016 15:10:06 +0200 > > Maxime Coquelin wrote: > > > > > This patch adds virtio_test_backend_virtio_1() function to > > > check whether backend supports VIRTIO_F_VERSION_1 before the > > > negociation takes place. > > > > s/negociation/negotiation/ > > > > > > > > Cc: Cornelia Huck > > > Cc: Marcel Apfelbaum > > > Cc: Michael S. Tsirkin > > > Cc: qemu-stable@nongnu.org > > > Signed-off-by: Maxime Coquelin > > > --- > > > hw/virtio/virtio.c | 13 +++++++++++++ > > > include/hw/virtio/virtio.h | 1 + > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > > > index 74c085c..8b30b69 100644 > > > --- a/hw/virtio/virtio.c > > > +++ b/hw/virtio/virtio.c > > > @@ -1481,6 +1481,19 @@ void virtio_vmstate_save(QEMUFile *f, void *opaque, size_t size) > > > virtio_save(VIRTIO_DEVICE(opaque), f); > > > } > > > > > > +bool virtio_test_backend_virtio_1(VirtIODevice *vdev, Error **errp) > > > +{ > > > + VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); > > > + uint64_t feature; > > > > As others had requested, I'd prefer setting this to 0 as well. > > > > With that changed: > > > > Reviewed-by: Cornelia Huck > Thanks Cornelia, > Note that if everyone agree to have patch adding pre_plugged, > this series will not be needed anymore. > > Regards, > Maxime Yes - that one needs testing for ccw and mmio. -- MST