From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org, idan.brown@ravellosystems.com,
Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net
Date: Mon, 12 Sep 2016 21:49:37 +0300 [thread overview]
Message-ID: <20160912214937.659b3098@halley> (raw)
In-Reply-To: <1473066662-4167-1-git-send-email-shmulik.ladkani@ravellosystems.com>
On Mon, 5 Sep 2016 12:11:02 +0300 Shmulik Ladkani <shmulik.ladkani@gmail.com> wrote:
> Upon hmp_host_net_remove(), the appropriate -net client is deleted
> (according to the given vlan_id and device id), as well as the
> corresponsing hub port.
>
> However, the relevant '-net' option that was added by former
> hmp_host_net_add() call is still present in "net" options group.
>
> This makes the following legit HMP sequence erroneous:
>
> (qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
> (qemu) host_net_remove 1 n1
> (qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
> Duplicate ID 'n1' for net
>
> Fix, by deleting the stored '-net' option associated with the given
> device id.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
ping?
next prev parent reply other threads:[~2016-09-12 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 9:11 [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net Shmulik Ladkani
2016-09-12 18:49 ` Shmulik Ladkani [this message]
2016-09-21 23:49 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912214937.659b3098@halley \
--to=shmulik.ladkani@gmail.com \
--cc=idan.brown@ravellosystems.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).