From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjagd-00036h-HS for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:30:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjagY-0006xR-II for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:30:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjagY-0006xD-Cj for qemu-devel@nongnu.org; Mon, 12 Sep 2016 19:30:46 -0400 Date: Mon, 12 Sep 2016 20:30:39 -0300 From: Eduardo Habkost Message-ID: <20160912233039.GA2794@thinpad.lan.raisama.net> References: <1467837300-17528-1-git-send-email-rth@twiddle.net> <35f23ccc-deba-1768-f75a-6b5a4f9fa4e8@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35f23ccc-deba-1768-f75a-6b5a4f9fa4e8@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Use struct X86XSaveArea in fpu_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Wed, Sep 07, 2016 at 09:47:07AM -0700, Richard Henderson wrote: > On 07/06/2016 01:35 PM, Richard Henderson wrote: > > This avoids a double hand-full of magic numbers in the > > xsave and xrstor helper functions. > > > > Signed-off-by: Richard Henderson > > --- > > target-i386/cpu.c | 7 ++- > > target-i386/cpu.h | 10 +---- > > target-i386/fpu_helper.c | 108 ++++++++++++++++++++++++++--------------------- > > 3 files changed, 67 insertions(+), 58 deletions(-) > > --- > > > > V2: Adjust struct X86XSaveHeader so as to retain the test for 16 bytes of > > zeros within xrstor. Comment on the slight inconsistency in two sections > > of the current Intel documentation. > > Ping. Applied to x86-next, thanks! -- Eduardo