From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjgAe-0002fz-I6 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 01:22:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjgAZ-000346-He for qemu-devel@nongnu.org; Tue, 13 Sep 2016 01:22:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjgAZ-00033t-CN for qemu-devel@nongnu.org; Tue, 13 Sep 2016 01:22:07 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2095D6370D for ; Tue, 13 Sep 2016 05:22:06 +0000 (UTC) Date: Tue, 13 Sep 2016 01:22:04 -0400 From: Jeff Cody Message-ID: <20160913052204.GC24087@localhost.localdomain> References: <1471715924-3642-1-git-send-email-prasanna.kalever@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471715924-3642-1-git-send-email-prasanna.kalever@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com, vbellur@redhat.com On Sat, Aug 20, 2016 at 11:28:44PM +0530, Prasanna Kumar Kalever wrote: > Added documentation describing relation between GlusterServer and > SocketAddress qapi schemas. > > Thanks to Markus Armbruster > > Signed-off-by: Prasanna Kumar Kalever > --- > v2: apply suggestions from Markus on v1 > v1: initial doc changes > --- > qapi/block-core.json | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5e2d7d7..4bd513f 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2121,6 +2121,18 @@ > # > # @tcp: host address and port number > # > +# This is similar to SocketAddress, only distinction: > +# > +# 1. GlusterServer is a flat union, SocketAddress is a simple union. > +# A flat union is nicer than simple because it avoids nesting > +# (i.e. more {}) on the wire. > +# > +# 2. GlusterServer lacks case 'fd', since gluster doesn't let you > +# pass in a file descriptor. > +# > +# GlusterServer is actually not Gluster-specific, its a > +# compatibility evolved into an alternate for SocketAddress. > +# > # Since: 2.7 > ## > { 'union': 'GlusterServer', > -- > 2.7.4 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff