* [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress
@ 2016-08-20 17:58 Prasanna Kumar Kalever
2016-09-12 15:05 ` Markus Armbruster
2016-09-13 5:22 ` Jeff Cody
0 siblings, 2 replies; 3+ messages in thread
From: Prasanna Kumar Kalever @ 2016-08-20 17:58 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru, eblake, jcody, vbellur, Prasanna Kumar Kalever
Added documentation describing relation between GlusterServer and
SocketAddress qapi schemas.
Thanks to Markus Armbruster <armbru@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
---
v2: apply suggestions from Markus on v1
v1: initial doc changes
---
qapi/block-core.json | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5e2d7d7..4bd513f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2121,6 +2121,18 @@
#
# @tcp: host address and port number
#
+# This is similar to SocketAddress, only distinction:
+#
+# 1. GlusterServer is a flat union, SocketAddress is a simple union.
+# A flat union is nicer than simple because it avoids nesting
+# (i.e. more {}) on the wire.
+#
+# 2. GlusterServer lacks case 'fd', since gluster doesn't let you
+# pass in a file descriptor.
+#
+# GlusterServer is actually not Gluster-specific, its a
+# compatibility evolved into an alternate for SocketAddress.
+#
# Since: 2.7
##
{ 'union': 'GlusterServer',
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress
2016-08-20 17:58 [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress Prasanna Kumar Kalever
@ 2016-09-12 15:05 ` Markus Armbruster
2016-09-13 5:22 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2016-09-12 15:05 UTC (permalink / raw)
To: Prasanna Kumar Kalever; +Cc: qemu-devel, jcody, vbellur
Prasanna Kumar Kalever <prasanna.kalever@redhat.com> writes:
> Added documentation describing relation between GlusterServer and
> SocketAddress qapi schemas.
>
> Thanks to Markus Armbruster <armbru@redhat.com>
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress
2016-08-20 17:58 [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress Prasanna Kumar Kalever
2016-09-12 15:05 ` Markus Armbruster
@ 2016-09-13 5:22 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2016-09-13 5:22 UTC (permalink / raw)
To: Prasanna Kumar Kalever; +Cc: qemu-devel, armbru, eblake, vbellur
On Sat, Aug 20, 2016 at 11:28:44PM +0530, Prasanna Kumar Kalever wrote:
> Added documentation describing relation between GlusterServer and
> SocketAddress qapi schemas.
>
> Thanks to Markus Armbruster <armbru@redhat.com>
>
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> ---
> v2: apply suggestions from Markus on v1
> v1: initial doc changes
> ---
> qapi/block-core.json | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 5e2d7d7..4bd513f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2121,6 +2121,18 @@
> #
> # @tcp: host address and port number
> #
> +# This is similar to SocketAddress, only distinction:
> +#
> +# 1. GlusterServer is a flat union, SocketAddress is a simple union.
> +# A flat union is nicer than simple because it avoids nesting
> +# (i.e. more {}) on the wire.
> +#
> +# 2. GlusterServer lacks case 'fd', since gluster doesn't let you
> +# pass in a file descriptor.
> +#
> +# GlusterServer is actually not Gluster-specific, its a
> +# compatibility evolved into an alternate for SocketAddress.
> +#
> # Since: 2.7
> ##
> { 'union': 'GlusterServer',
> --
> 2.7.4
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-13 5:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-20 17:58 [Qemu-devel] [PATCH v2 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress Prasanna Kumar Kalever
2016-09-12 15:05 ` Markus Armbruster
2016-09-13 5:22 ` Jeff Cody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).