From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjku4-0006dw-Eh for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjku0-0002YT-NL for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjku0-0002YH-G5 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:25:20 -0400 Date: Tue, 13 Sep 2016 11:25:14 +0100 From: "Daniel P. Berrange" Message-ID: <20160913102513.GO30949@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473088600-17930-1-git-send-email-berrange@redhat.com> <1473088600-17930-4-git-send-email-berrange@redhat.com> <87h99lozur.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87h99lozur.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v11 3/6] qapi: rename QmpInputVisitor to QObjectInputVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Max Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= On Mon, Sep 12, 2016 at 06:19:08PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The QmpInputVisitor has no direct dependancy on QMP. It is > > valid to use it anywhere that one has a QObject. Rename it > > to better reflect its functionality as a generic QObject > > to QAPI convertor. > > > > Signed-off-by: Daniel P. Berrange > > --- > > docs/qapi-code-gen.txt | 2 +- > > ...qmp-input-visitor.h => qobject-input-visitor.h} | 10 +- > > monitor.c | 2 +- > > qapi/Makefile.objs | 2 +- > > ...qmp-input-visitor.c => qobject-input-visitor.c} | 171 +++++++++++---------- > > qmp.c | 4 +- > > qom/qom-qobject.c | 4 +- > > scripts/qapi-commands.py | 4 +- > > tests/.gitignore | 4 +- > > tests/Makefile.include | 12 +- > > tests/check-qnull.c | 4 +- > > tests/test-qmp-commands.c | 4 +- > > ...-input-strict.c => test-qobject-input-strict.c} | 4 +- > > ...nput-visitor.c => test-qobject-input-visitor.c} | 4 +- > > tests/test-string-input-visitor.c | 2 +- > > tests/test-visitor-serialization.c | 4 +- > > util/qemu-sockets.c | 2 +- > > 17 files changed, 121 insertions(+), 118 deletions(-) > > rename include/qapi/{qmp-input-visitor.h => qobject-input-visitor.h} (63%) > > rename qapi/{qmp-input-visitor.c => qobject-input-visitor.c} (56%) > > rename tests/{test-qmp-input-strict.c => test-qobject-input-strict.c} (99%) > > rename tests/{test-qmp-input-visitor.c => test-qobject-input-visitor.c} (99%) > > $ git-grep -Ei 'qmp.?input.*?vis' > include/qapi/visitor.h: * the dealloc and QMP input/output visitors are general, the string, > target-s390x/cpu_models.c:#include "qapi/qmp-input-visitor.h" > target-s390x/cpu_models.c: visitor = qmp_input_visitor_new(info->props, true); > tests/test-qobject-input-strict.c: * QMP Input Visitor unit-tests (strict mode). > tests/test-qobject-input-visitor.c: * QMP Input Visitor unit-tests. Opps, yes will fix those. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|