From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjlWR-0001sU-Kn for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjlWI-0006cw-6d for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjlWH-0006cX-Ud for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:04:54 -0400 Date: Tue, 13 Sep 2016 12:04:47 +0100 From: "Daniel P. Berrange" Message-ID: <20160913110447.GS30949@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-2-git-send-email-arei.gonglei@huawei.com> <20160913091349.GC30949@redhat.com> <24b41240-bb25-fb63-b1df-a12c682d173f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24b41240-bb25-fb63-b1df-a12c682d173f@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 01/15] crypto: introduce cryptodev backend and crypto legacy hardware List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gonglei , qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, peter.huangpeng@huawei.com, luonengjun@huawei.com, mst@redhat.com, stefanha@redhat.com, weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de, xin.zeng@intel.com, claudio.fontana@huawei.com, nmorey@kalray.eu, vincent.jardin@6wind.com On Tue, Sep 13, 2016 at 12:50:53PM +0200, Paolo Bonzini wrote: > > > On 13/09/2016 11:13, Daniel P. Berrange wrote: > > > + * Permission is hereby granted, free of charge, to any person obtaining a copy > > > + * of this software and associated documentation files (the "Software"), to deal > > > + * in the Software without restriction, including without limitation the rights > > > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > > > + * copies of the Software, and to permit persons to whom the Software is > > > + * furnished to do so, subject to the following conditions: > > > + * > > > + * The above copyright notice and this permission notice shall be included in > > > + * all copies or substantial portions of the Software. > > > + * > > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > > > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > > > + * THE SOFTWARE. > > > + */ > > > > New files are expected to be submitted under the GPLv2+ license, > > unless they're header files imported from an external project, > > which this is not. > > This is not true. New files are expected to be submitted under a > GPLv2+-compatible license, which this one is. If you want to copy code snippets from existing files which are GPLv2+ licensed, into this new file, then that'd be a license violation as this new file is granting broader permissions which the original code did not grant. So I still believe this should be GPLv2+ unless there is a compelling reason why it cannot be. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|