From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1bjpb8-0006xZ-Nj
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:26:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1bjpb2-0000lc-Ne
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:26:10 -0400
Date: Tue, 13 Sep 2016 11:25:52 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20160913152552.GD24087@localhost.localdomain>
References: <1473745333-7548-1-git-send-email-jcody@redhat.com>
	<1473745333-7548-2-git-send-email-jcody@redhat.com>
	<8ef98a4a-c44b-3074-e213-7b7e46c66410@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8ef98a4a-c44b-3074-e213-7b7e46c66410@redhat.com>
Subject: Re: [Qemu-devel] [PULL 1/2] block/gluster: add support to choose
 libgfapi logfile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org

On Tue, Sep 13, 2016 at 10:23:32AM -0500, Eric Blake wrote:
> On 09/13/2016 12:42 AM, Jeff Cody wrote:
> > From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> > 
> > currently all the libgfapi logs defaults to '/dev/stderr' as it was hardcoded
> > in a call to glfs logging api. When the debug level is chosen to DEBUG/TRACE,
> > gfapi logs will be huge and fill/overflow the console view.
> > 
> > This patch provides a commandline option to mention log file path which helps
> > in logging to the specified file and also help in persisting the gfapi logs.
> > 
> 
> > +++ b/qapi/block-core.json
> > @@ -2154,13 +2154,16 @@
> >  #
> >  # @debug-level: #optional libgfapi log level (default '4' which is Error)
> >  #
> > +# @logfile:     #optional libgfapi log file (default /dev/stderr)
> > +#
> >  # Since: 2.7
> 
> logfile missed 2.7; please add a '(since 2.8)' designator on the
> @logfile line as a followup patch.
> 
>

Yep, thanks for catching that Eric.