Re: [Qemu-devel] [PATCH v2 2/7] qemu-img: add iflag and oflag options to dd

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On Fri, Aug 26, 2016 at 11:16:38AM +0200, Reda Sallahi wrote:
> This adds the iflag and oflag options which defines the list of flags used
> for reading and writing respectively. The list is comma-separated.
> 
> The iflag option supports direct, dsync, sync, count_bytes and skip_bytes
> and oflag supports direct, dsync, sync and seek_bytes. They are similar to
> their counterparts on GNU dd(1).
> 
> Two tests were added to test iflag and oflag.
> 
> Signed-off-by: Reda Sallahi <fullmanet@gmail.com>
> ---
>  qemu-img-cmds.hx           |   4 +-
>  qemu-img.c                 | 172 +++++++++++++++++++++++++++++++++++++++------
>  qemu-img.texi              |  32 +++++++--
>  tests/qemu-iotests/163     | 103 +++++++++++++++++++++++++++
>  tests/qemu-iotests/163.out | 135 +++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/164     | 100 ++++++++++++++++++++++++++
>  tests/qemu-iotests/164.out |  75 ++++++++++++++++++++
>  tests/qemu-iotests/group   |   2 +
>  8 files changed, 595 insertions(+), 28 deletions(-)
>  create mode 100755 tests/qemu-iotests/163
>  create mode 100644 tests/qemu-iotests/163.out
>  create mode 100755 tests/qemu-iotests/164
>  create mode 100644 tests/qemu-iotests/164.out

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]