From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjpoH-0003Ls-TO for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjpoC-0001gD-Sj for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:39:44 -0400 Received: from 5.mo6.mail-out.ovh.net ([46.105.54.31]:50151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjpoC-0001fX-Mg for qemu-devel@nongnu.org; Tue, 13 Sep 2016 11:39:40 -0400 Received: from player693.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 71511FFAA37 for ; Tue, 13 Sep 2016 17:39:39 +0200 (CEST) Date: Tue, 13 Sep 2016 17:39:33 +0200 From: Greg Kurz Message-ID: <20160913173933.4844ba9d@bahia> In-Reply-To: <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/LudT6RGGOd.BDMZ48foKnjd"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Alexey Kardashevskiy , qemu-devel@nongnu.org --Sig_/LudT6RGGOd.BDMZ48foKnjd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 13 Sep 2016 09:49:09 -0500 Eric Blake wrote: > On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: > > The tap backend is already using qemu-bridge-helper to attach tap > > interface to a bridge but (unlike the bridge backend) it always uses > > the default bridge name - br0. > >=20 > > This adds a "br" property support to the tap backend. > >=20 > > Signed-off-by: Alexey Kardashevskiy > > -- > > Changes: > > v2: > > * documented a new member in json and hx > > --- > > net/tap.c | 4 +++- > > qapi-schema.json | 3 +++ > > qemu-options.hx | 12 +++++++----- > > 3 files changed, 13 insertions(+), 6 deletions(-) > > =20 >=20 > > +++ b/qapi-schema.json > > @@ -2575,6 +2575,8 @@ > > # > > # @downscript: #optional script to shut down the interface > > # > > +# @br: #optional bridge name =20 >=20 > Missing a '(since 2.8)' designator. >=20 > Also, we don't have to abbreviate; 'bridge-name' may be easier to > understand than 'br', as well as a mention of the default value if the > parameter is not supplied. >=20 FWIW @br is consistent with what we already have in NetdevBridgeOptions since 1.2. > > +# > > # @helper: #optional command to execute to configure bridge > > # > > # @sndbuf: #optional send buffer limit. Understands [TGMKkb] suffixes. > > @@ -2604,6 +2606,7 @@ > > '*fds': 'str', > > '*script': 'str', > > '*downscript': 'str', > > + '*br': 'str', > > '*helper': 'str', > > '*sndbuf': 'size', > > '*vnet_hdr': 'bool', =20 >=20 > Oh, we already use underscore, so if you go with a longer name, > 'bridge_name' would be more consistent than 'bridge-name', even though > we prefer dash over underscore in new interfaces. >=20 --Sig_/LudT6RGGOd.BDMZ48foKnjd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlfYHbUACgkQAvw66wEB28KWmQCggGs810mIZPVfZvVE/6ORZuS/ S+IAn2JDHdFX6umktLYGLaX3H+rHAN77 =L3i2 -----END PGP SIGNATURE----- --Sig_/LudT6RGGOd.BDMZ48foKnjd--