Re: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1473798735-6290-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PULL 0/5] virtio,pci: fixes and updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1473798735-6290-1-git-send-email-mst@redhat.com -> patchew/1473798735-6290-1-git-send-email-mst@redhat.com
Switched to a new branch 'test'
e7a4ce2 hw/i386: AMD IOMMU IVRS table
69dfd17 hw/i386: Introduce AMD IOMMU
577db28 hw/i386/trace-events: Add AMD IOMMU trace events
da2c51f hw/pci: Prepare for AMD IOMMU
c64cb29 virtio-bus: Plug devices after features are negotiated

=== OUTPUT BEGIN ===
Checking PATCH 1/5: virtio-bus: Plug devices after features are negotiated...
Checking PATCH 2/5: hw/pci: Prepare for AMD IOMMU...
Checking PATCH 3/5: hw/i386/trace-events: Add AMD IOMMU trace events...
Checking PATCH 4/5: hw/i386: Introduce AMD IOMMU...
ERROR: struct MemoryRegionIOMMUOps should normally be const
#1707: FILE: hw/i386/amd_iommu.h:280:
+    MemoryRegionIOMMUOps iommu_ops;

total: 1 errors, 0 warnings, 1677 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: hw/i386: AMD IOMMU IVRS table...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org