From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42210)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk14I-0000J5-8f
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:41:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk14C-00074M-Mi
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:41:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk14C-00073E-Gh
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:40:56 -0400
Date: Wed, 14 Sep 2016 11:40:51 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160914034051.GD15357@lemon>
References: <1473822299-6302-1-git-send-email-wanpeng.li@hotmail.com>
	<20160914032140.19908.55883@ex-std-node742.prod.rhcloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160914032140.19908.55883@ex-std-node742.prod.rhcloud.com>
Subject: Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is
 split
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kernellwp@gmail.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, rkrcmar@redhat.com, pbonzini@redhat.com, wanpeng.li@hotmail.com

On Tue, 09/13 20:21, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
> 
> Your series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 1473822299-6302-1-git-send-email-wanpeng.li@hotmail.com
> Subject: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 9bcacc6 pc: apic: fix touch LAPIC when irqchip is split
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: pc: apic: fix touch LAPIC when irqchip is split...
> ERROR: suspect code indent for conditional statements (4, 9)
> #90: FILE: hw/i386/pc.c:164:
> +    if (!kvm_irqchip_in_kernel()) {
> +         intno = apic_get_interrupt(cpu->apic_state);
       ^^^^^
Should be 4 spaces here.

> 
> ERROR: suspect code indent for conditional statements (9, 13)
> #92: FILE: hw/i386/pc.c:166:
> +         if (intno >= 0) {
> +             return intno;

Then this and later will be indented back by 1 column.

Fam