From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk5VC-0000kM-Vu for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:25:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bk5VA-0004Ef-N9 for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:25:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk5VA-0004EV-Gg for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:25:04 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE37CC04D31B for ; Wed, 14 Sep 2016 08:25:03 +0000 (UTC) Date: Wed, 14 Sep 2016 09:25:00 +0100 From: "Daniel P. Berrange" Message-ID: <20160914082500.GB28399@redhat.com> Reply-To: "Daniel P. Berrange" References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <87vay6ed9t.fsf@fimbulvetr.bsc.es> <20160913170804.GD30949@redhat.com> <877faffxzq.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877faffxzq.fsf@fimbulvetr.bsc.es> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi On Tue, Sep 13, 2016 at 08:36:25PM +0200, Llu=C3=ADs Vilanova wrote: > Daniel P Berrange writes: >=20 > > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Llu=C3=ADs Vilanova wrote: > >> Daniel P Berrange writes: > >>=20 > >> > I previously split the global trace-events file up into one file > >> > per-subdirectory to avoid merge conflict hell. > >> [...] > >>=20 > >> Sorry, I could not find the message where the infrastructure is modi= fied to > >> provide this. But I think there's a more efficient way to provide mo= dular > >> auto-generated tracing code without the hierarchical indexing you pr= oposed. >=20 > > NB, the simpletrace backend requires a globally unique 32-bit integer= ID > > to be assigned to each trace event, so even with the approach you sug= gest > > below we still need to be able to assign a global ID for each event. >=20 > > So while your suggest below avoids having to pass around the dstate > > arrays, which is nice, we still have to assign event id offsets to > > each trace-event file in some manner TBD. >=20 > Corect me if I'm wrong, but if we only require these consecutive IDs fo= r > simpletrace, they don't need to be visible to the tracing headers (thes= e IDs are > only used in "trace/generated-tracers.c"). Therefore, we can get them f= rom the > trace-events-all file, and minimize the complexity of the changes to tr= acetool. The IDs need to be present in the generated tracers files which are split up. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|