From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk7QE-0008P8-3N
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 06:28:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk7QA-00020G-TJ
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 06:28:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bk7QA-0001zw-Ny
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 06:28:02 -0400
Date: Wed, 14 Sep 2016 18:27:58 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160914102758.GA21372@lemon>
References: <1473843994-16004-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1473843994-16004-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] memory: remove
 memory_region_destructor_rom_device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, herongguang.he@huawei.com

On Wed, 09/14 11:06, Paolo Bonzini wrote:
> It is equivalent to memory_region_destructor_ram, use that one.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  memory.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/memory.c b/memory.c
> index 0eb6895..5ed3872 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -943,10 +943,6 @@ static void memory_region_destructor_ram(MemoryRegion *mr)
>  {
>      qemu_ram_free(mr->ram_block);
>  }
> -
> -static void memory_region_destructor_rom_device(MemoryRegion *mr)
> -{
> -    qemu_ram_free(mr->ram_block);
>  }

You want to remove the closing brace line too.

Fam

>  
>  static bool memory_region_need_escape(char c)
> @@ -1405,7 +1401,7 @@ void memory_region_init_rom_device(MemoryRegion *mr,
>      mr->opaque = opaque;
>      mr->terminates = true;
>      mr->rom_device = true;
> -    mr->destructor = memory_region_destructor_rom_device;
> +    mr->destructor = memory_region_destructor_ram;
>      mr->ram_block = qemu_ram_alloc(size, mr, errp);
>  }
>  
> -- 
> 2.7.4
> 
>