From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bk9MH-0008Mh-U2
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 08:32:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bk9MF-0002IN-PF
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 08:32:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bk9MF-0002IJ-JO
	for qemu-devel@nongnu.org; Wed, 14 Sep 2016 08:32:07 -0400
Date: Wed, 14 Sep 2016 13:32:02 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160914123202.GM28399@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1470756748-18933-1-git-send-email-berrange@redhat.com>
	<1470756748-18933-6-git-send-email-berrange@redhat.com>
	<20160902205218.GD21771@stefanha-x1.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160902205218.GD21771@stefanha-x1.localdomain>
Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event
 iterator APIs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Fri, Sep 02, 2016 at 04:52:18PM -0400, Stefan Hajnoczi wrote:
> On Tue, Aug 09, 2016 at 04:31:33PM +0100, Daniel P. Berrange wrote:
> > +TraceEvent *trace_event_iter_next(TraceEventIter *iter)
> > +{
> > +    TraceEvent *ev;
> > +
> > +    if (iter->event >= TRACE_EVENT_COUNT) {
> > +        return NULL;
> > +    }
> > +
> > +    ev = &(trace_events[iter->event]);
> > +
> > +    do {
> > +        iter->event++;
> > +    } while (iter->event < TRACE_EVENT_COUNT &&
> > +             iter->pattern &&
> > +             !pattern_glob(iter->pattern,
> > +                           trace_event_get_name(&(trace_events[iter->event]))));
> > +
> > +    return ev;
> > +}
> 
> Shouldn't ev be updated inside the while loop?  Otherwise the iterator
> always returns &trace_events[0] the first time it's called.

Sigh, yes, well spotted.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|