From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, jferlan@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
pl@kamp.de, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi=<iscsi-id> parameter
Date: Wed, 14 Sep 2016 16:15:29 +0100 [thread overview]
Message-ID: <20160914151529.GL16438@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160908081410.GA30602@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Sep 08, 2016 at 09:14:10AM +0100, Daniel P. Berrange wrote:
> On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote:
> > Add a parameter to associate an iSCSI block driver instance with an -iscsi
> > object. This is more powerful than relying on the implicit target IQN naming
> > convention since that only allows one -iscsi object per target.
>
> I'm inclined to say we should *not* do this, as it just serves to perpetuate
> usage of the insane -iscsi arg. Instead we could focus on fixing the iSCSI
> blockdev for 2.8 so that it directly supports properties for everything that
> you can set via -iscsi and deprecate -iscsi entirely. We've got enough time
> during 2.8 to get this entirely converted I think.
That's fine. There's not much advantage to defining -iscsi objects
except that a single -iscsi can be used by multiple iscsi drives.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-09-14 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 21:23 [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi=<iscsi-id> parameter Stefan Hajnoczi
2016-09-07 21:23 ` [Qemu-devel] [PATCH 1/3] iscsi: extract find_iscsi_opts() helper function Stefan Hajnoczi
2016-09-07 21:23 ` [Qemu-devel] [PATCH 2/3] iscsi: simplify -iscsi QemuOpts fetching Stefan Hajnoczi
2016-09-07 21:23 ` [Qemu-devel] [PATCH 3/3] iscsi: add iscsi=<iscsi-id> option Stefan Hajnoczi
2016-09-08 8:14 ` [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi=<iscsi-id> parameter Daniel P. Berrange
2016-09-14 15:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914151529.GL16438@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=jferlan@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).