From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBuS-0006YY-6V for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBuP-0004z6-8D for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBuO-0004yv-Qf for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:15:32 -0400 Date: Wed, 14 Sep 2016 16:15:29 +0100 From: Stefan Hajnoczi Message-ID: <20160914151529.GL16438@stefanha-x1.localdomain> References: <1473283392-31292-1-git-send-email-stefanha@redhat.com> <20160908081410.GA30602@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CqfQkoYPE/jGoa5Q" Content-Disposition: inline In-Reply-To: <20160908081410.GA30602@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, jferlan@redhat.com, Paolo Bonzini , pl@kamp.de, ronniesahlberg@gmail.com --CqfQkoYPE/jGoa5Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2016 at 09:14:10AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote: > > Add a parameter to associate an iSCSI block driver instance with an -is= csi > > object. This is more powerful than relying on the implicit target IQN = naming > > convention since that only allows one -iscsi object per target. >=20 > I'm inclined to say we should *not* do this, as it just serves to perpetu= ate > usage of the insane -iscsi arg. Instead we could focus on fixing the iSCSI > blockdev for 2.8 so that it directly supports properties for everything t= hat > you can set via -iscsi and deprecate -iscsi entirely. We've got enough ti= me > during 2.8 to get this entirely converted I think. That's fine. There's not much advantage to defining -iscsi objects except that a single -iscsi can be used by multiple iscsi drives. Stefan --CqfQkoYPE/jGoa5Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX2WmRAAoJEJykq7OBq3PIHhMH/RisGfwBzGnPQX5ohYFCoKzX /xGMTN9kMJzKy7yU/WRwYTlslSfN2r/Nvp+gh3A/C0U5+z04y9WTLy7RQQ5Leoho KM7ZtexTdp8n2zM3R19Wq+kRhBHjQkNhg4tivDU2FWjb0qnjGF4LhNkTr0CcqL6g qPZUHTgoGNibROSOqNFbQqkCTWnWEJpYkioA461xJtz2o+QJfQ1r6TfFv/ovg8eJ u8kNopg0mxOqaYzYuzqANaPcivLCOiW/ORU+HEjSRk0r2NKKk1HFm7Xqv/MSOrj+ w0gCja6iJcxmx+MFvEGUAFSJOsa1+E/meNVFidiJxHFI9SFoj9Hlok9I82RhIfs= =wVyu -----END PGP SIGNATURE----- --CqfQkoYPE/jGoa5Q--