From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkCoK-0000jH-97 for qemu-devel@nongnu.org; Wed, 14 Sep 2016 12:13:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkCoF-0006Ly-FV for qemu-devel@nongnu.org; Wed, 14 Sep 2016 12:13:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkCoF-0006Ls-AT for qemu-devel@nongnu.org; Wed, 14 Sep 2016 12:13:15 -0400 Date: Wed, 14 Sep 2016 17:13:10 +0100 From: "Daniel P. Berrange" Message-ID: <20160914161310.GY28399@redhat.com> Reply-To: "Daniel P. Berrange" References: <147377800565.11859.4411044563640180545.stgit@brijesh-build-machine> <147377806784.11859.11149856529336910514.stgit@brijesh-build-machine> <20160913155807.GA2850@thinpad.lan.raisama.net> <6411b07f-4edd-390c-acca-5342ab1187ba@amd.com> <20160913220044.GY24695@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC PATCH v1 06/22] sev: add initial SEV support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh Cc: Eduardo Habkost , crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Wed, Sep 14, 2016 at 11:10:54AM -0500, Brijesh Singh wrote: > > I am open to idea and need direction on which way to go. I will work on > documenting the parameters and usages. Should I consider implementing your > below approach in v2 ? > > -object sev-launch-rule,flags=0,policy=0,dh_pub_qx=XXXXX,dh_pub_qy=YYYYY,nonce=ZZZZ,vcpu_count=1,vcpu_length=30,vcpu_mask=00ab > \ -machine pc,accel=kvm,sev=on > > Any tips on which qemu file i can use as reference during implementation. Take a look at crypto/secret.c for an example of how to create a QOM object that can be loaded with '-object'. There are more examples in backends/{hostmem,rng}*.c too. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|