From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkDGV-0006zw-RU for qemu-devel@nongnu.org; Wed, 14 Sep 2016 12:42:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkDGU-0005pD-1S for qemu-devel@nongnu.org; Wed, 14 Sep 2016 12:42:26 -0400 Date: Wed, 14 Sep 2016 18:42:20 +0200 From: Kevin Wolf Message-ID: <20160914164220.GI4649@noname.redhat.com> References: <33e655a4c33767e9274f81ae2e0ad914c532dc02.1473867966.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33e655a4c33767e9274f81ae2e0ad914c532dc02.1473867966.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Am 14.09.2016 um 17:52 hat Alberto Garcia geschrieben: > We're only doing this immediately before opening the image, but > bs->open_flags is used earlier in the function. At the moment this is > not causing problems because none of the checked flags are modified by > update_flags_from_options(), but this will change when we introduce > the "read-only" option. > > This patch calls update_flags_from_options() at the beginning of the > function, immediately after creating the QemuOpts. > > Signed-off-by: Alberto Garcia Reviewed-by: Kevin Wolf