From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkKV1-0000db-Ou for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:25:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkKUy-0004Th-Em for qemu-devel@nongnu.org; Wed, 14 Sep 2016 20:25:54 -0400 Date: Thu, 15 Sep 2016 10:10:29 +1000 From: David Gibson Message-ID: <20160915001029.GB15077@voom.fritz.box> References: <1473878907-10477-1-git-send-email-lvivier@redhat.com> <1473878907-10477-6-git-send-email-lvivier@redhat.com> <86153a33-3f6e-7837-d5f4-f0ef62717c36@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pS0IeWLqOQV1qy0L" Content-Disposition: inline In-Reply-To: <86153a33-3f6e-7837-d5f4-f0ef62717c36@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Laurent Vivier , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --pS0IeWLqOQV1qy0L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2016 at 03:09:31PM -0500, Eric Blake wrote: > On 09/14/2016 01:48 PM, Laurent Vivier wrote: > > Signed-off-by: Laurent Vivier > > --- > > hw/scsi/spapr_vscsi.c | 89 +++++++++++++++++++++----------------------= -------- > > hw/scsi/trace-events | 27 ++++++++++++++++ > > 2 files changed, 63 insertions(+), 53 deletions(-) > >=20 >=20 > > +++ b/hw/scsi/trace-events > > @@ -202,3 +202,30 @@ esp_pci_dma_abort(uint32_t val) "ABORT (%.8x)" > > esp_pci_dma_start(uint32_t val) "START (%.8x)" > > esp_pci_sbac_read(uint32_t reg) "sbac: 0x%8.8x" > > esp_pci_sbac_write(uint32_t reg, uint32_t val) "sbac: 0x%8.8x -> 0x%8.= 8x" > > + > > +# hw/scsi/spapr_vscsi.c > > + > > +spapr_vscsi_send_rsp(uint8_t status, int32_t res_in, int32_t res_out) = "status: 0x%x, res_in: %"PRId32", res_out: %"PRId32 >=20 > Same as before. I've removed these blank lines as I merged. > > +spapr_vscsi_fetch_desc_no_data(void) "no data descriptor" > > +spapr_vscsi_fetch_desc_direct(void) "direct segment" > > +spapr_vscsi_fetch_desc_indirect(uint32_t qtag, unsigned desc, unsigned= local_desc) "indirect segment local tag=3D0x%"PRIx32" desc#%u/%u" > > +spapr_vscsi_fetch_desc_out_of_range(unsigned desc, unsigned desc_offse= t) "#%u is ouf of range (%u bytes)" > > +spapr_vscsi_fetch_desc_dma_read_error(int rc) "spapr_vio_dma_read -> %= d reading ext_desc" > > +spapr_vscsi_fetch_desc_indirect_seg_ext(uint32_t qtag, unsigned n, uns= igned desc, uint64_t va, uint32_t len) "indirect segment ext. tag=3D0x%"PRI= x32" desc#%u/%u { va=3D0x%"PRIx64" len=3D0x%"PRIx32" }" > > +spapr_vscsi_fetch_desc_out_of_desc(void) "Out of descriptors !" >=20 > Probably worth dropping the ' !' while touching this (first, English > doesn't want space before !; second, ! usually means you are shouting at > the user, and doesn't appear in many other traces as a result). That's a good change, but I'd prefer to see it as a follow up patch. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --pS0IeWLqOQV1qy0L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX2eb1AAoJEGw4ysog2bOSFqMP/0lCETMme0dT5YavTA3Di5E/ xCHuVbK3cy3XabDREzQcUIwkfIRDi83dtsObYqxBlb4ypfTTWZfFMxuaMDTblfMY SSBb5u1dJbw/0e3maco73kDzcDVg+7q8IrhlFmydJXm5W3RCjeQv735AFjK7AtPS LGdU5Vxp+uamofjh3tpiAy63Blz5IYsXXmTrgdn46iscjKua8iCV0vWAj6yEsg2F F91x5nD+vLA+kfU68i6+9mtaTeyAVMCjWpGRRq6hnolbZ+zqX5lmcIO+PpZUxKSZ 7Z2gHIxCVhGqYHMEyPFhs94DZkOnInknL4TCzVZ4LSA6cIHCm6EE4awmTP4xaMhk 5xwLhyEnJODN8NM50UKfpDVeHIqIoZUWiTGw/WJEnL+gO+iK5fVtIuB/5bg0kgTi U3XLGkr2Qdt0+wyOtngEm62le67kpt5Q2E5vL4gxM7hZGC1LDjMkQUV+D1gKDPuS DkjoBizEU/u9gKklIoyrkT8Cb5mmAP2mCn5uOG2XIxunS6k5AzqYAWUsci+HN34h mxlZJ7U0HDzgaWeImYFuj/wdptGB8OeUwEDDi6F32DAmxtppXwplrgkJUxDpJTKm Wde0VQvTLcpY3dqafhooZjdZwlfB62rPgHhYEJlY1Zk/7p0Uu6l7l96fGTXG9zsh teInPHSewGKSNzv9bE+v =cIKe -----END PGP SIGNATURE----- --pS0IeWLqOQV1qy0L--