From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkNV8-0004ZK-QE for qemu-devel@nongnu.org; Wed, 14 Sep 2016 23:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkNV7-0001uj-UP for qemu-devel@nongnu.org; Wed, 14 Sep 2016 23:38:14 -0400 Date: Thu, 15 Sep 2016 09:42:51 +0800 From: Fam Zheng Message-ID: <20160915014251.GA10143@lemon> References: <1473043845-13197-1-git-send-email-famz@redhat.com> <20160914143525.GE16438@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 0/3] block: Fix libbz2 library dependency regresssion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org, pbonzini@redhat.com, Kevin Wolf On Wed, 09/14 16:48, Max Reitz wrote: > On 2016-09-14 at 16:35, Stefan Hajnoczi wrote: > > On Mon, Sep 05, 2016 at 10:50:42AM +0800, Fam Zheng wrote: > > > v4: Remove unused variable in patch 1 and unwanted warning in patch 2. [Max] > > > > > > v3: Fix typo in copyright header. [Max] > > > Fix pre-existing type casting. [Max] > > > > > > v2: Rebase on top of Max's block-next tree, which has Colin's patches to > > > dynamically load block modules. > > > Two more tweaks to the module system is added. > > > > > > v1 was submitted as a single patch: > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg00508.html > > > > > > Fam Zheng (3): > > > scripts: Allow block module to not define BlockDriver > > > module: Don't load the same module if requested multiple times > > > dmg: Move libbz2 code to dmg-bz2.so > > > > > > block/Makefile.objs | 3 +- > > > block/dmg-bz2.c | 62 ++++++++++++++++++++++++++++++++++++ > > > block/dmg.c | 69 ++++++++++------------------------------- > > > block/dmg.h | 59 +++++++++++++++++++++++++++++++++++ > > > scripts/modules/module_block.py | 7 ----- > > > util/module.c | 18 +++++++++-- > > > 6 files changed, 156 insertions(+), 62 deletions(-) > > > create mode 100644 block/dmg-bz2.c > > > create mode 100644 block/dmg.h > > > > Max was the last one to comment on this series. I'll wait for him to > > review this before applying it. > > Looks good to me, but I'm afraid this series might depend on my block-next > (now block) branch which has not been merged to master yet, actually. So > maybe I should apply it instead? ;-) Yes, please! Fam