From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkSXd-00064R-Or for qemu-devel@nongnu.org; Thu, 15 Sep 2016 05:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkSXc-0001pQ-UM for qemu-devel@nongnu.org; Thu, 15 Sep 2016 05:01:09 -0400 Received: from mail.ispras.ru ([83.149.199.45]:38932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkSXc-0001oe-N4 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 05:01:08 -0400 From: Pavel Dovgalyuk Date: Thu, 15 Sep 2016 12:01:00 +0300 Message-ID: <20160915090100.6440.17683.stgit@PASHA-ISP> In-Reply-To: <20160915090042.6440.22516.stgit@PASHA-ISP> References: <20160915090042.6440.22516.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v2 03/10] block: don't make snapshots for filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, agraf@suse.de, pbonzini@redhat.com, david@gibson.dropbear.id.au This patch disables snapshotting for block driver filters. It is needed, because snapshots should be created in underlying disk images, not in filters itself. Signed-off-by: Pavel Dovgalyuk --- block/snapshot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/snapshot.c b/block/snapshot.c index bf5c2ca..8998b8b 100644 --- a/block/snapshot.c +++ b/block/snapshot.c @@ -184,6 +184,9 @@ int bdrv_snapshot_goto(BlockDriverState *bs, if (!drv) { return -ENOMEDIUM; } + if (drv->is_filter) { + return 0; + } if (drv->bdrv_snapshot_goto) { return drv->bdrv_snapshot_goto(bs, snapshot_id); }