Re: [Qemu-devel] [PATCH 2/3] tests: virtio-9p: add basic configuration test

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Fri, 09 Sep 2016 10:04:51 +0200
Greg Kurz <groug@kaod.org> wrote:

> This adds PCI init code and a basic test that checks the device config
> matches what is passed on the command line.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  tests/Makefile.include |    2 +
>  tests/virtio-9p-test.c |   82 +++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 81 insertions(+), 3 deletions(-)

> +static const char mount_tag[] = "qtest";
>  static char *test_share;
> 
>  static void qvirtio_9p_start(void)
> @@ -21,8 +29,8 @@ static void qvirtio_9p_start(void)
>      g_assert_nonnull(mkdtemp(test_share));
> 
>      args = g_strdup_printf("-fsdev local,id=fsdev0,security_model=none,path=%s "
> -                           "-device virtio-9p-pci,fsdev=fsdev0,mount_tag=qtest",
> -                           test_share);
> +                           "-device virtio-9p-pci,fsdev=fsdev0,mount_tag=%s",
> +                           test_share, mount_tag);
> 
>      qtest_start(args);
>      g_free(args);

Maybe move this change to patch 1?