From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkW2W-0001Og-PY for qemu-devel@nongnu.org; Thu, 15 Sep 2016 08:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkW2T-0006ce-DA for qemu-devel@nongnu.org; Thu, 15 Sep 2016 08:45:16 -0400 Received: from 19.mo6.mail-out.ovh.net ([188.165.56.177]:35369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkW2T-0006cH-76 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 08:45:13 -0400 Received: from player776.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 67991FFB479 for ; Thu, 15 Sep 2016 14:45:12 +0200 (CEST) Date: Thu, 15 Sep 2016 14:45:06 +0200 From: Greg Kurz Message-ID: <20160915144506.61f651b1@bahia> In-Reply-To: <20160915104138.709e8690.cornelia.huck@de.ibm.com> References: <147340827736.6462.8546871953640244651.stgit@bahia> <20160915104138.709e8690.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, "Aneesh Kumar K.V" , "Michael S. Tsirkin" On Thu, 15 Sep 2016 10:41:38 +0200 Cornelia Huck wrote: > On Fri, 09 Sep 2016 10:04:37 +0200 > Greg Kurz wrote: > > > As with other virtio-* qtests, PC platform is assumed. > > > > --- > > > > Greg Kurz (3): > > tests: virtio-9p: introduce start/stop functions > > tests: virtio-9p: add basic configuration test > > tests: virtio-9p: add basic transaction test > > > > > > tests/Makefile.include | 2 - > > tests/virtio-9p-test.c | 179 ++++++++++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 164 insertions(+), 17 deletions(-) > > > > I took a quick look and nothing bad jumped out at me, but that is > probably not saying much :/ > Not much is a lot more than nothing, as it is usually the case with 9pfs patches that don't fix security issues or deprecated glibc calls ;) Can this "nothing bad jumped out" be formalized into an Acked-by ? Thanks. -- Greg