qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p
Date: Thu, 15 Sep 2016 15:04:30 +0200	[thread overview]
Message-ID: <20160915150430.0176992a.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160915144506.61f651b1@bahia>

On Thu, 15 Sep 2016 14:45:06 +0200
Greg Kurz <groug@kaod.org> wrote:

> On Thu, 15 Sep 2016 10:41:38 +0200
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> 
> > On Fri, 09 Sep 2016 10:04:37 +0200
> > Greg Kurz <groug@kaod.org> wrote:
> > 
> > > As with other virtio-* qtests, PC platform is assumed.
> > > 
> > > ---
> > > 
> > > Greg Kurz (3):
> > >       tests: virtio-9p: introduce start/stop functions
> > >       tests: virtio-9p: add basic configuration test
> > >       tests: virtio-9p: add basic transaction test
> > > 
> > > 
> > >  tests/Makefile.include |    2 -
> > >  tests/virtio-9p-test.c |  179 ++++++++++++++++++++++++++++++++++++++++++++----
> > >  2 files changed, 164 insertions(+), 17 deletions(-)
> > >   
> > 
> > I took a quick look and nothing bad jumped out at me, but that is
> > probably not saying much :/
> > 
> 
> Not much is a lot more than nothing, as it is usually the case with 9pfs
> patches that don't fix security issues or deprecated glibc calls ;)
> 
> Can this "nothing bad jumped out" be formalized into an Acked-by ?

Feel free:

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>

      reply	other threads:[~2016-09-15 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  8:04 [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 1/3] tests: virtio-9p: introduce start/stop functions Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 2/3] tests: virtio-9p: add basic configuration test Greg Kurz
2016-09-15  8:40   ` Cornelia Huck
2016-09-15 12:09     ` Greg Kurz
2016-09-09  8:04 ` [Qemu-devel] [PATCH 3/3] tests: virtio-9p: add basic transaction test Greg Kurz
2016-09-09  8:10 ` [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p no-reply
2016-09-15  7:45 ` Greg Kurz
2016-09-15  8:41 ` Cornelia Huck
2016-09-15 12:45   ` Greg Kurz
2016-09-15 13:04     ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915150430.0176992a.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=groug@kaod.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).