From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkv2n-0000ti-4Q for qemu-devel@nongnu.org; Fri, 16 Sep 2016 11:27:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkv2k-0000wB-4S for qemu-devel@nongnu.org; Fri, 16 Sep 2016 11:27:13 -0400 Date: Fri, 16 Sep 2016 16:27:05 +0100 From: "Daniel P. Berrange" Message-ID: <20160916152704.GD9654@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474034177-17663-1-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1474034177-17663-1-git-send-email-lvivier@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Fri, Sep 16, 2016 at 03:55:51PM +0200, Laurent Vivier wrote: > This series is the result of coccinelle patch > scripts/coccinelle/exit.cocci > provided by the first patch of the series. > > It replaces exit(0) by exit(EXIT_SUCCESS) > and exit(1) by exit(EXIT_FAILURE). Some places use '_exit' and should have had the same change applied AFAICT. > All other exit() are not modified as we don't want > to change the behavior. IMHO, modifying the other exit() calls is precisely what would make this series useful. eg there's a bunch of places which arbitrarily use '-1' instead of '1' as the value for no good reason. Consolidating the inconsistent use of -1 and 1 would have functional benefit. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|