From: Jeff Cody <jcody@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
sw@weilnetz.de, mdroth@linux.vnet.ibm.com, armbru@redhat.com,
pbonzini@redhat.com, mreitz@redhat.com, eblake@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v8 02/12] uuid: Make null_uuid static
Date: Sun, 18 Sep 2016 23:31:04 -0400 [thread overview]
Message-ID: <20160919033104.GB32304@localhost.localdomain> (raw)
In-Reply-To: <1474172732-31994-3-git-send-email-famz@redhat.com>
On Sun, Sep 18, 2016 at 12:25:22PM +0800, Fam Zheng wrote:
> So that it doesn't have to be zeroed at each call.
>
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> util/uuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/uuid.c b/util/uuid.c
> index 6815904..f0c1eeb 100644
> --- a/util/uuid.c
> +++ b/util/uuid.c
> @@ -40,7 +40,7 @@ void qemu_uuid_generate(QemuUUID *uuid)
>
> int qemu_uuid_is_null(const QemuUUID *uu)
> {
> - QemuUUID null_uuid = { 0 };
> + static QemuUUID null_uuid;
> return memcmp(uu, &null_uuid, sizeof(QemuUUID)) == 0;
> }
>
> --
> 2.7.4
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
next prev parent reply other threads:[~2016-09-19 3:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 4:25 [Qemu-devel] [PATCH v8 00/12] UUID clean ups for 2.8 Fam Zheng
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 01/12] util: Add UUID API Fam Zheng
2016-09-19 3:30 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 02/12] uuid: Make null_uuid static Fam Zheng
2016-09-19 3:31 ` Jeff Cody [this message]
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 03/12] vhdx: Use QEMU UUID API Fam Zheng
2016-09-19 3:33 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 04/12] vdi: " Fam Zheng
2016-09-19 3:33 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 05/12] vpc: " Fam Zheng
2016-09-19 3:33 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 06/12] crypto: Switch to " Fam Zheng
2016-09-19 3:34 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 07/12] tests: No longer dependent on CONFIG_UUID Fam Zheng
2016-09-19 3:34 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 08/12] configure: Remove detection code for UUID Fam Zheng
2016-09-19 3:34 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 09/12] vl: Switch qemu_uuid to QemuUUID Fam Zheng
2016-09-19 3:34 ` Jeff Cody
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 10/12] uuid: Tighten uuid parse Fam Zheng
2016-09-19 3:44 ` Jeff Cody
2016-09-19 20:30 ` Eric Blake
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 11/12] tests: Add uuid tests Fam Zheng
2016-09-19 3:44 ` Jeff Cody
2016-09-20 15:37 ` Eric Blake
2016-09-21 3:32 ` Fam Zheng
2016-09-18 4:25 ` [Qemu-devel] [PATCH v8 12/12] Add UUID files to MAINTAINERS Fam Zheng
2016-09-19 3:44 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919033104.GB32304@localhost.localdomain \
--to=jcody@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).